[Password Generation] Send a boolean flag of whether user changed generated password

chrome/browser/ui/autofill/password_generation_popup_controller_impl.h

Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
index 168a6d900bbc8cb6e45648c304a59b60f939837e..c789dd123e282904b68c661a5aaf311532a177cf 100644
--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
@@ -76,7 +76,6 @@ class PasswordGenerationPopupControllerImpl
       const gfx::RectF& bounds,
       const PasswordForm& form,
       int max_length,
-      password_manager::PasswordManager* password_manager,
       password_manager::PasswordManagerDriver* driver,
       PasswordGenerationPopupObserver* observer,
       content::WebContents* web_contents,
@@ -127,7 +126,6 @@ class PasswordGenerationPopupControllerImpl
   void CalculateBounds();
 
   PasswordForm form_;
-  password_manager::PasswordManager* password_manager_;

[vabr (Chromium), 2017/06/16 12:32:29]

While I applaud to removing dead code, perhaps this could have been a separate
CL, because it is not really related to the main goal of the CL. If you could
extract this ("git cl split" might help), feel free to just TBR to me and land
the change in c/b/ui/autofill.

[kolos1, 2017/06/21 13:46:12]

This code became dead because of removing the call of SetHasGeneratedPassword in
password_generation_popup_controller_impl.cc. Removing of SetHas... is
nondetachable part of this CL.

[vabr (Chromium), 2017/06/21 14:18:33]

You are right, sorry that I missed that.

   password_manager::PasswordManagerDriver* driver_;
 
   // May be NULL.