Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 2937033002: [Password Generation] Send a boolean flag of whether user changed generated password (Closed)
Patch Set: UMA fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc
index e4ed9f70800446feb8141ee565fbee0a998aad22..0f4df51dcc05a8029508d4d31525385b2ef36a1c 100644
--- a/components/password_manager/core/browser/password_form_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc
@@ -184,6 +184,11 @@ MATCHER_P2(CheckUploadedGenerationTypesAndSignature,
<< ", but found " << field->generation_type();
return false;
}
+
+ if (field->generation_type() !=
+ autofill::AutofillUploadContents::Field::IGNORED_GENERATION_POPUP) {
+ EXPECT_TRUE(field->generated_password_changed());
+ }
}
}
return true;
@@ -656,6 +661,8 @@ class PasswordFormManagerTest : public testing::Test {
form_manager.set_generation_element(generation_element);
form_manager.set_generation_popup_was_shown(true);
form_manager.set_has_generated_password(has_generated_password);
+ if (has_generated_password)
+ form_manager.set_generated_password_changed(true);
// Figure out expected generation event type.
autofill::AutofillUploadContents::Field::PasswordGenerationType

Powered by Google App Engine
This is Rietveld 408576698