[Password Generation] Send a boolean flag of whether user changed generated password

chrome/browser/ui/autofill/password_generation_popup_controller_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_PASSWORD_GENERATION_POPUP_CONTROLLER_IMPL_H_
 #define CHROME_BROWSER_UI_AUTOFILL_PASSWORD_GENERATION_POPUP_CONTROLLER_IMPL_H_
 
 #include <stddef.h>
 #include <string>
 
@@ skipping 58 matching lines @@
   void Show(bool display_password);
 
   // Hides the popup and destroys |this|.
   void HideAndDestroy();
 
  protected:
   PasswordGenerationPopupControllerImpl(
       const gfx::RectF& bounds,
       const PasswordForm& form,
       int max_length,
-      password_manager::PasswordManager* password_manager,
       password_manager::PasswordManagerDriver* driver,
       PasswordGenerationPopupObserver* observer,
       content::WebContents* web_contents,
       gfx::NativeView container_view);
 
   // Handle to the popup. May be NULL if popup isn't showing.
   PasswordGenerationPopupView* view_;
 
  private:
   // PasswordGenerationPopupController implementation:
@@ skipping 30 matching lines @@
   void PasswordSelected(bool selected);
 
   // Accept password if it's selected.
   bool PossiblyAcceptPassword();
 
   // Get desired size of popup. Height depends on width because we do text
   // wrapping.
   void CalculateBounds();
 
   PasswordForm form_;
-  password_manager::PasswordManager* password_manager_;

[vabr (Chromium), 2017/06/16 12:32:29]

While I applaud to removing dead code, perhaps this could have been a separate
CL, because it is not really related to the main goal of the CL. If you could
extract this ("git cl split" might help), feel free to just TBR to me and land
the change in c/b/ui/autofill.

[kolos1, 2017/06/21 13:46:12]

This code became dead because of removing the call of SetHasGeneratedPassword in
password_generation_popup_controller_impl.cc. Removing of SetHas... is
nondetachable part of this CL.

[vabr (Chromium), 2017/06/21 14:18:33]

You are right, sorry that I missed that.

   password_manager::PasswordManagerDriver* driver_;
 
   // May be NULL.
   PasswordGenerationPopupObserver* observer_;
 
   // Controls how passwords are generated.
   std::unique_ptr<PasswordGenerator> generator_;
 
   // Contains common popup data.
   const PopupControllerCommon controller_common_;
@@ skipping 17 matching lines @@
   content::WebContents* const web_contents_;
 
   base::WeakPtrFactory<PasswordGenerationPopupControllerImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordGenerationPopupControllerImpl);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_PASSWORD_GENERATION_POPUP_CONTROLLER_IMPL_H_