Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2936973003: Revert "Workaround for Qualcomm renderbuffer resize bug" (Closed)

Created:
3 years, 6 months ago by marcheu1
Modified:
3 years, 6 months ago
Reviewers:
piman, kainino
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Workaround for Qualcomm renderbuffer resize bug" This reverts commit 10b29d38bbd2eb90d7d93fb07214d468f7af7dde. This breaks WebGL on ARM Chromebooks. BUG=chromium:732616 TEST=webgl works again on Chrome OS CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2936973003 Cr-Commit-Position: refs/heads/master@{#479289} Committed: https://chromium.googlesource.com/chromium/src/+/a2205e65faf366cf1748e6a72c4a41188b07e05b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -160 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 13 chunks +46 lines, -80 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +1 line, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 3 chunks +18 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.h View 2 chunks +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M gpu/config/gpu_driver_bug_list.json View 9 chunks +29 lines, -17 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 7 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
marcheu1
On 2017/06/14 00:15:27, marcheu1 wrote: > mailto:marcheu@google.com changed reviewers: > + mailto:kainino@google.com, mailto:piman@chromium.org It's mostly ...
3 years, 6 months ago (2017-06-14 00:15:45 UTC) #4
piman
lgtm
3 years, 6 months ago (2017-06-14 00:25:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936973003/1
3 years, 6 months ago (2017-06-14 03:56:10 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 05:03:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2205e65faf366cf1748e6a72c4a...

Powered by Google App Engine
This is Rietveld 408576698