Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: gpu/command_buffer/service/renderbuffer_manager.cc

Issue 2936973003: Revert "Workaround for Qualcomm renderbuffer resize bug" (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/renderbuffer_manager.h ('k') | gpu/config/gpu_driver_bug_list.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/renderbuffer_manager.cc
diff --git a/gpu/command_buffer/service/renderbuffer_manager.cc b/gpu/command_buffer/service/renderbuffer_manager.cc
index 2174fb9370eabc721fb557eaecd4b9cffd482c72..d734547073422f817b169d131e1dab7d194107b9 100644
--- a/gpu/command_buffer/service/renderbuffer_manager.cc
+++ b/gpu/command_buffer/service/renderbuffer_manager.cc
@@ -103,7 +103,6 @@ void Renderbuffer::SetInfoAndInvalidate(GLsizei samples,
width_ = width;
height_ = height;
cleared_ = false;
- allocated_ = true;
for (auto& point : framebuffer_attachment_points_) {
point.first->UnmarkAsComplete();
}
@@ -128,7 +127,6 @@ Renderbuffer::Renderbuffer(RenderbufferManager* manager,
client_id_(client_id),
service_id_(service_id),
cleared_(true),
- allocated_(false),
has_been_bound_(false),
samples_(0),
internal_format_(GL_RGBA4),
@@ -137,33 +135,6 @@ Renderbuffer::Renderbuffer(RenderbufferManager* manager,
manager_->StartTracking(this);
}
-bool Renderbuffer::RegenerateAndBindBackingObjectIfNeeded() {
- if (!allocated_ || !has_been_bound_ || samples_ == 0) {
- // Not needed - won't trigger bug (multisample_renderbuffer_resize_broken).
- return false;
- }
-
- GLint original_fbo = 0;
- glGetIntegerv(GL_DRAW_FRAMEBUFFER_BINDING, &original_fbo);
-
- glDeleteRenderbuffersEXT(1, &service_id_);
- service_id_ = 0;
- glGenRenderbuffersEXT(1, &service_id_);
- glBindRenderbufferEXT(GL_RENDERBUFFER, service_id_);
-
- // Attach new renderbuffer to all framebuffers
- for (auto& point : framebuffer_attachment_points_) {
- glBindFramebufferEXT(GL_DRAW_FRAMEBUFFER, point.first->service_id());
- glFramebufferRenderbufferEXT(GL_DRAW_FRAMEBUFFER, point.second,
- GL_RENDERBUFFER, service_id_);
- }
-
- glBindFramebufferEXT(GL_DRAW_FRAMEBUFFER, original_fbo);
-
- allocated_ = false;
- return true;
-}
-
void Renderbuffer::AddFramebufferAttachmentPoint(Framebuffer* framebuffer,
GLenum attachment) {
framebuffer_attachment_points_.insert(
« no previous file with comments | « gpu/command_buffer/service/renderbuffer_manager.h ('k') | gpu/config/gpu_driver_bug_list.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698