Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2936763004: Revert of chromium.webkit: Run Layout Tests on Swarming (on Linux bots). (Closed)

Created:
3 years, 6 months ago by mithro
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke, mcgreevy
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chromium.webkit: Run Layout Tests on Swarming (on Linux bots). (patchset #3 id:40001 of https://codereview.chromium.org/2924713004/ ) Reason for revert: The extra test expectation files needed by the bots are not included in the isolate (or not referenced correctly). https://chromium-swarm.appspot.com/task?id=36ba424f86833510&refresh=10&request_detail=true&show_raw=1 05:33:12.601 15501 additional_expectations path 'src/third_party/WebKit/LayoutTests/LeakExpectations' does not exist Original issue's description: > chromium.webkit: Run Layout Tests on Swarming (on Linux bots). > > Converts the WebKit waterfall bots to run layout tests on swarming. > > Land https://crrev.com/c/526534 for the recipe side change after this CL lands. > > BUG=703894, 524758 > NOTRY=true > > Review-Url: https://codereview.chromium.org/2924713004 > Cr-Commit-Position: refs/heads/master@{#478980} > Committed: https://chromium.googlesource.com/chromium/src/+/48d4f56053dec8d56dd0a1caa1fb253ebba3b8ec TBR=dpranke@chromium.org,mcgreevy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703894, 524758 Review-Url: https://codereview.chromium.org/2936763004 Cr-Commit-Position: refs/heads/master@{#478997} Committed: https://chromium.googlesource.com/chromium/src/+/3ae8e680460dd0c2ce98da659e0839000ded0d23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -176 lines) Patch
M testing/buildbot/chromium.webkit.json View 5 chunks +1 line, -176 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mithro
Created Revert of chromium.webkit: Run Layout Tests on Swarming (on Linux bots).
3 years, 6 months ago (2017-06-13 13:30:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936763004/1
3 years, 6 months ago (2017-06-13 13:30:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3ae8e680460dd0c2ce98da659e0839000ded0d23
3 years, 6 months ago (2017-06-13 13:31:23 UTC) #6
Dirk Pranke
3 years, 6 months ago (2017-06-13 16:08:03 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698