|
|
Chromium Code Reviews
Descriptionchromium.webkit: Run Layout Tests on Swarming (on Linux bots).
Converts the WebKit waterfall bots to run layout tests on swarming.
Land https://crrev.com/c/526534 for the recipe side change after this CL lands.
BUG=703894, 524758
NOTRY=true
Review-Url: https://codereview.chromium.org/2924713004
Cr-Commit-Position: refs/heads/master@{#479309}
Committed: https://chromium.googlesource.com/chromium/src/+/87486756658e0131876b8694b6a25ad1110dd50d
Patch Set 1 #Patch Set 2 : chromium.webkit: Run Layout Tests on Swarming (on Linux bots). #Patch Set 3 : Rebase onto master #Patch Set 4 : Fixing expectation paths for reland. #Messages
Total messages: 42 (32 generated)
tansell@chromium.org changed reviewers: + dpranke@chromium.org, mcgreevy@chromium.org
Hi! I'm not sure this is 100% right. There don't appear to be existing configurations for MSAN/TSAN in the JSON files? There is a change in the infra repo which removes the BlinkTest from recipe_modules/chromium_tests/chromium_webkit.py which I will upload shortly and will need to be landed after this change goes live. There will be a short period where it is possible for both the BlinkTest and the JSON configured test will be run. Tim 'mithro' Ansell
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. BUG=703894,524758 ========== to ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/526534 for the recipe side change after this CL lands. BUG=703894,524758 ==========
On 2017/06/07 02:05:34, mithro wrote: > Hi! > > I'm not sure this is 100% right. There don't appear to be existing > configurations for MSAN/TSAN in the JSON files? Yup, and you can see that they're not actually running the gtest tests as a result. This CL will add them, which is probably a good thing. LGTM.
Description was changed from ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/526534 for the recipe side change after this CL lands. BUG=703894,524758 ========== to ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c526534 for the recipe side change after this CL lands. BUG=703894,524758 ==========
Description was changed from ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c526534 for the recipe side change after this CL lands. BUG=703894,524758 ========== to ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 ==========
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by tansell@chromium.org
The CQ bit was checked by tansell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2924713004/#ps40001 (title: "Rebase onto master")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 ========== to ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true ==========
The CQ bit was unchecked by tansell@chromium.org
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497356239278880,
"parent_rev": "f58c9cc4ef204c86920191756ea4e4cf4de94379", "commit_rev":
"48d4f56053dec8d56dd0a1caa1fb253ebba3b8ec"}
Message was sent while issue was closed.
Description was changed from ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true ========== to ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true Review-Url: https://codereview.chromium.org/2924713004 Cr-Commit-Position: refs/heads/master@{#478980} Committed: https://chromium.googlesource.com/chromium/src/+/48d4f56053dec8d56dd0a1caa1fb... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/48d4f56053dec8d56dd0a1caa1fb...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2936763004/ by tansell@chromium.org. The reason for reverting is: The extra test expectation files needed by the bots are not included in the isolate (or not referenced correctly). https://chromium-swarm.appspot.com/task?id=36ba424f86833510&refresh=10&reques... 05:33:12.601 15501 additional_expectations path 'src/third_party/WebKit/LayoutTests/LeakExpectations' does not exist .
Message was sent while issue was closed.
Description was changed from ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true Review-Url: https://codereview.chromium.org/2924713004 Cr-Commit-Position: refs/heads/master@{#478980} Committed: https://chromium.googlesource.com/chromium/src/+/48d4f56053dec8d56dd0a1caa1fb... ========== to ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true Review-Url: https://codereview.chromium.org/2924713004 Cr-Commit-Position: refs/heads/master@{#478980} Committed: https://chromium.googlesource.com/chromium/src/+/48d4f56053dec8d56dd0a1caa1fb... ==========
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true Review-Url: https://codereview.chromium.org/2924713004 Cr-Commit-Position: refs/heads/master@{#478980} Committed: https://chromium.googlesource.com/chromium/src/+/48d4f56053dec8d56dd0a1caa1fb... ========== to ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 Review-Url: https://codereview.chromium.org/2924713004 Cr-Commit-Position: refs/heads/master@{#478980} Committed: https://chromium.googlesource.com/chromium/src/+/48d4f56053dec8d56dd0a1caa1fb... ==========
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 Review-Url: https://codereview.chromium.org/2924713004 Cr-Commit-Position: refs/heads/master@{#478980} Committed: https://chromium.googlesource.com/chromium/src/+/48d4f56053dec8d56dd0a1caa1fb... ========== to ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true ==========
The CQ bit was unchecked by tansell@chromium.org
The CQ bit was checked by tansell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2924713004/#ps60001 (title: "Fixing expectation paths for reland.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497422991163470,
"parent_rev": "d1b870f2cf4bece0726cc8a89aa36f2fe38d73ad", "commit_rev":
"87486756658e0131876b8694b6a25ad1110dd50d"}
Message was sent while issue was closed.
Description was changed from ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true ========== to ========== chromium.webkit: Run Layout Tests on Swarming (on Linux bots). Converts the WebKit waterfall bots to run layout tests on swarming. Land https://crrev.com/c/526534 for the recipe side change after this CL lands. BUG=703894,524758 NOTRY=true Review-Url: https://codereview.chromium.org/2924713004 Cr-Commit-Position: refs/heads/master@{#479309} Committed: https://chromium.googlesource.com/chromium/src/+/87486756658e0131876b8694b6a2... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/87486756658e0131876b8694b6a2... |
