[turbofan] Refactor property access building.

[turbofan] Refactor property access building.

This is in preparation for lowering monomorphic loads during graph building.

This essentially moves the parts that will be shared to a separate class/file
(proparty-access-builder.(cc|h)).

I should say that we will not want to do accessor inlining during graph
building because that would require us to create frame states
(which is the thing we would like to avoid doing).

Review-Url: https://codereview.chromium.org/2936673005
Cr-Commit-Position: refs/heads/master@{#45973}
Committed: https://chromium.googlesource.com/v8/v8/+/126451d319f56a74371ae954e1e7abd30ac2da06

[Jarin, 2017-06-13 09:29:25]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 09:29:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 09:36:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 09:36:41]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[Jarin, 2017-06-13 10:39:00]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 10:39:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 11:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 11:05:57]

Dry run: This issue passed the CQ dry run.

[Jarin, 2017-06-16 06:52:39]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 06:52:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-06-16 06:53:23]

jarin@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Jarin, 2017-06-16 06:53:24]

Could you take a look, please?

[commit-bot: I haz the power, 2017-06-16 07:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 07:36:37]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2017-06-16 08:32:22]

LGTM, just nits. Thanks!

https://codereview.chromium.org/2936673005/diff/60001/src/compiler/js-native-...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2936673005/diff/60001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:1576: bool
store_to_constant_field = FLAG_track_constant_fields &&
nit: Indentation looks off starting here, all the way down to 1732 below.

https://codereview.chromium.org/2936673005/diff/60001/src/compiler/property-a...
File src/compiler/property-access-builder.h (right):

https://codereview.chromium.org/2936673005/diff/60001/src/compiler/property-a...
src/compiler/property-access-builder.h:72: static bool
HasOnlyNumberMaps(MapHandles const& maps);
nit: Can we remove these static helpers from the header and put them into an
anonymous namespace in the .cc-file instead?

[Jarin, 2017-06-16 08:40:37]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 08:40:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 09:25:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 09:25:52]

Dry run: This issue passed the CQ dry run.

[Jarin, 2017-06-16 09:32:27]

https://codereview.chromium.org/2936673005/diff/60001/src/compiler/js-native-...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2936673005/diff/60001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:1576: bool
store_to_constant_field = FLAG_track_constant_fields &&
On 2017/06/16 08:32:22, Michael Starzinger wrote:
> nit: Indentation looks off starting here, all the way down to 1732 below.

Done.

https://codereview.chromium.org/2936673005/diff/60001/src/compiler/property-a...
File src/compiler/property-access-builder.h (right):

https://codereview.chromium.org/2936673005/diff/60001/src/compiler/property-a...
src/compiler/property-access-builder.h:72: static bool
HasOnlyNumberMaps(MapHandles const& maps);
On 2017/06/16 08:32:22, Michael Starzinger wrote:
> nit: Can we remove these static helpers from the header and put them into an
> anonymous namespace in the .cc-file instead?

Done.

[Jarin, 2017-06-16 09:32:32]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2017-06-16 09:32:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2936673005/#ps80001
(title: "Address reviewer comments")

[commit-bot: I haz the power, 2017-06-16 09:32:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 09:34:05]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497605552191900,
"parent_rev": "e47f37ebd0d7eebeb0c6dcd28a86ad354843567a", "commit_rev":
"126451d319f56a74371ae954e1e7abd30ac2da06"}

[commit-bot: I haz the power, 2017-06-16 09:34:13]

Description was changed from

==========
[turbofan] Refactor property access building.

This is in preparation for lowering monomorphic loads during graph building.

This essentially moves the parts that will be shared to a separate class/file
(proparty-access-builder.(cc|h)).

I should say that we will not want to do accessor inlining during graph
building because that would require us to create frame states
(which is the thing we would like to avoid doing).
==========

to

==========
[turbofan] Refactor property access building.

This is in preparation for lowering monomorphic loads during graph building.

This essentially moves the parts that will be shared to a separate class/file
(proparty-access-builder.(cc|h)).

I should say that we will not want to do accessor inlining during graph
building because that would require us to create frame states
(which is the thing we would like to avoid doing).

Review-Url: https://codereview.chromium.org/2936673005
Cr-Commit-Position: refs/heads/master@{#45973}
Committed:
https://chromium.googlesource.com/v8/v8/+/126451d319f56a74371ae954e1e7abd30ac...
==========

[commit-bot: I haz the power, 2017-06-16 09:34:14]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/126451d319f56a74371ae954e1e7abd30ac...