[ObjC ARC] Converts ios/chrome/browser/ui/authentication:authentication to ARC.

ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.h"
 
-#import "base/ios/weak_nsobject.h"
 #import "base/mac/foundation_util.h"
-#import "base/mac/scoped_nsobject.h"
 #include "base/metrics/user_metrics.h"
 #import "base/strings/sys_string_conversions.h"
 #include "components/google/core/browser/google_util.h"
 #include "ios/chrome/browser/application_context.h"
 #include "ios/chrome/browser/signin/chrome_identity_service_observer_bridge.h"
 #import "ios/chrome/browser/ui/authentication/account_control_item.h"
 #import "ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome.h"
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_footer_item.h"
 #import "ios/chrome/browser/ui/collection_view/collection_view_model.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #import "ios/chrome/common/string_util.h"
 #include "ios/chrome/grit/ios_chromium_strings.h"
 #include "ios/chrome/grit/ios_strings.h"
 #include "ios/public/provider/chrome/browser/chrome_browser_provider.h"
 #include "ios/public/provider/chrome/browser/images/branded_image_provider.h"
 #import "ios/public/provider/chrome/browser/signin/chrome_identity.h"
 #import "ios/public/provider/chrome/browser/signin/chrome_identity_service.h"
 #include "ios/public/provider/chrome/browser/signin/signin_resources_provider.h"
 #import "ios/third_party/material_components_ios/src/components/AppBar/src/MaterialAppBar.h"
 #import "ios/third_party/material_components_ios/src/components/Palettes/src/MaterialPalettes.h"
 #import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"
 #import "ui/base/l10n/l10n_util.h"
 #include "url/gurl.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace {
 const CGFloat kAccountImageDimension = 64.;
 const CGFloat kHeaderViewMinHeight = 170.;
 const CGFloat kHeaderViewHeightMultiplier = 0.33;
 const CGFloat kContentViewBottomInset = 40.;
 // Leading separator inset.
 const CGFloat kLeadingSeparatorInset = 30.;
 // Trailing separator inset.
 const CGFloat kTrailingSeparatorInset = 16.;
 
@@ skipping 24 matching lines @@
   ItemTypeGoogleServices,
   ItemTypeFooter,
 };
 }
 
 #pragma mark - SigninConfirmationViewController
 
 @interface SigninConfirmationViewController ()<
     ChromeIdentityServiceObserver,
     CollectionViewFooterLinkDelegate> {
-  base::scoped_nsobject<ChromeIdentity> _identity;
+  ChromeIdentity* _identity;
   std::unique_ptr<ChromeIdentityServiceObserverBridge> _identityServiceObserver;
-  base::WeakNSObject<UIImage> _oldImage;
-  base::scoped_nsobject<UIImageView> _imageView;
-  base::scoped_nsobject<UILabel> _titleLabel;
-  base::scoped_nsobject<UILabel> _emailLabel;
+  __weak UIImage* _oldImage;
+  UIImageView* _imageView;
+  UILabel* _titleLabel;
+  UILabel* _emailLabel;
 }
 @end
 
 @implementation SigninConfirmationViewController
 
 @synthesize delegate;
 
 - (instancetype)initWithIdentity:(ChromeIdentity*)identity {
   self = [super initWithStyle:CollectionViewControllerStyleAppBar];
   if (self) {
-    _identity.reset([identity retain]);
+    _identity = identity;
     _identityServiceObserver.reset(
         new ChromeIdentityServiceObserverBridge(self));
   }
   return self;
 }
 
 - (void)scrollToBottom {
   CGPoint bottomOffset = CGPointMake(
       0, self.collectionView.contentSize.height -
              self.collectionView.bounds.size.height + kContentViewBottomInset);
@@ skipping 33 matching lines @@
                                         .collectionViewContentSize.height];
   if (!didSend && [self isMovingToParentViewController]) {
     // The confirmation screen just appeared and there wasn't enough space to
     // show the full screen (since the scroll hasn't reach the botton). This
     // means the "More" button is actually necessary.
     base::RecordAction(base::UserMetricsAction("Signin_MoreButton_Shown"));
   }
 }
 
 - (UIView*)contentViewWithFrame:(CGRect)frame {
-  base::scoped_nsobject<UIView> contentView(
-      [[UIView alloc] initWithFrame:frame]);
-  contentView.get().autoresizingMask =
+  UIView* contentView = [[UIView alloc] initWithFrame:frame];
+  contentView.autoresizingMask =
       (UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight);
-  contentView.get().clipsToBounds = YES;
-  _imageView.reset([[UIImageView alloc] init]);
-  _imageView.get().translatesAutoresizingMaskIntoConstraints = NO;
+  contentView.clipsToBounds = YES;
+  _imageView = [[UIImageView alloc] init];
+  _imageView.translatesAutoresizingMaskIntoConstraints = NO;
 
-  _titleLabel.reset([[UILabel alloc] initWithFrame:CGRectZero]);
-  _titleLabel.get().textColor = [[MDCPalette greyPalette] tint900];
-  _titleLabel.get().font = [MDCTypography headlineFont];
-  _titleLabel.get().translatesAutoresizingMaskIntoConstraints = NO;
+  _titleLabel = [[UILabel alloc] initWithFrame:CGRectZero];
+  _titleLabel.textColor = [[MDCPalette greyPalette] tint900];
+  _titleLabel.font = [MDCTypography headlineFont];
+  _titleLabel.translatesAutoresizingMaskIntoConstraints = NO;
 
-  _emailLabel.reset([[UILabel alloc] initWithFrame:CGRectZero]);
-  _emailLabel.get().textColor = [[MDCPalette greyPalette] tint700];
-  _emailLabel.get().font = [MDCTypography body1Font];
-  _emailLabel.get().translatesAutoresizingMaskIntoConstraints = NO;
+  _emailLabel = [[UILabel alloc] initWithFrame:CGRectZero];
+  _emailLabel.textColor = [[MDCPalette greyPalette] tint700];
+  _emailLabel.font = [MDCTypography body1Font];
+  _emailLabel.translatesAutoresizingMaskIntoConstraints = NO;
 
   [self updateViewWithIdentity:_identity];
 
-  base::scoped_nsobject<UIView> divider(
-      [[UIView alloc] initWithFrame:CGRectZero]);
-  divider.get().backgroundColor = [[MDCPalette greyPalette] tint300];
-  divider.get().translatesAutoresizingMaskIntoConstraints = NO;
+  UIView* divider = [[UIView alloc] initWithFrame:CGRectZero];
+  divider.backgroundColor = [[MDCPalette greyPalette] tint300];
+  divider.translatesAutoresizingMaskIntoConstraints = NO;
 
-  base::scoped_nsobject<UILayoutGuide> layoutGuide1(
-      [[UILayoutGuide alloc] init]);
-  base::scoped_nsobject<UILayoutGuide> layoutGuide2(
-      [[UILayoutGuide alloc] init]);
+  UILayoutGuide* layoutGuide1 = [[UILayoutGuide alloc] init];
+  UILayoutGuide* layoutGuide2 = [[UILayoutGuide alloc] init];
 
   [contentView addSubview:_imageView];
   [contentView addSubview:_titleLabel];
   [contentView addSubview:_emailLabel];
   [contentView addSubview:divider];
   [contentView addLayoutGuide:layoutGuide1];
   [contentView addLayoutGuide:layoutGuide2];
 
   NSDictionary* views = @{
     @"image" : _imageView,
     @"title" : _titleLabel,
     @"email" : _emailLabel,
     @"divider" : divider,
     @"v1" : layoutGuide1,
     @"v2" : layoutGuide2
   };
   NSArray* constraints = @[
     @"V:[image]-(24)-[title]-(8)-[email]-(16)-[divider(==1)]|",
     @"H:|[v1][image]",
     @"H:|[v1(16)][title(<=440)][v2(>=v1)]|",
     @"H:|[v1][email]",
     @"H:|[divider]|",
   ];
   ApplyVisualConstraints(constraints, views);
-  return contentView.autorelease();
+  return contentView = nil;

[msarda, 2017/06/12 12:49:13]

I think this is wrong (does this compile?). Should it just be: "return
contentView"?

If this was generated by an automatic tool, it would be good to fix the cases
when using scoped_nsobject.autorelease.

[marq (ping after 24h), 2017/06/12 14:20:40]

Fixed. Yes, it compiles, since = returns the assigned value as a side effect. 

I'll keep an eye out for this case and fix the tool if it happens again.

 }
 
 - (void)viewWillLayoutSubviews {
   CGSize viewSize = self.view.bounds.size;
   MDCFlexibleHeaderView* headerView =
       self.appBar.headerViewController.headerView;
   headerView.maximumHeight =
       MAX(kHeaderViewMinHeight, kHeaderViewHeightMultiplier * viewSize.height);
 }
 
 - (void)updateViewWithIdentity:(ChromeIdentity*)identity {
   UIImage* identityImage = GetImageForIdentity(identity);
-  if (_oldImage.get() != identityImage) {
-    _oldImage.reset(identityImage);
+  if (_oldImage != identityImage) {
+    _oldImage = identityImage;
     identityImage =
         ResizeImage(identityImage,
                     CGSizeMake(kAccountImageDimension, kAccountImageDimension),
                     ProjectionMode::kAspectFit);
     identityImage =
         CircularImageFromImage(identityImage, kAccountImageDimension);
-    _imageView.get().image = identityImage;
+    _imageView.image = identityImage;
   }
 
-  _titleLabel.get().text = l10n_util::GetNSStringF(
+  _titleLabel.text = l10n_util::GetNSStringF(
       IDS_IOS_ACCOUNT_CONSISTENCY_CONFIRMATION_TITLE,
       base::SysNSStringToUTF16([identity userFullName]));
 
-  _emailLabel.get().text = [identity userEmail];
+  _emailLabel.text = [identity userEmail];
 }
 
 #pragma mark - Model
 
 - (void)loadModel {
   [super loadModel];
   CollectionViewModel* model = self.collectionViewModel;
 
   [model addSectionWithIdentifier:SectionIdentifierInfo];
   [model addItem:[self syncItem] toSectionWithIdentifier:SectionIdentifierInfo];
   [model addItem:[self googleServicesItem]
       toSectionWithIdentifier:SectionIdentifierInfo];
   [model addItem:[self openSettingsItem]
       toSectionWithIdentifier:SectionIdentifierInfo];
 }
 
 #pragma mark - Model items
 
 - (CollectionViewItem*)syncItem {
   AccountControlItem* item =
-      [[[AccountControlItem alloc] initWithType:ItemTypeSync] autorelease];
+      [[AccountControlItem alloc] initWithType:ItemTypeSync];
   item.text = l10n_util::GetNSString(
       IDS_IOS_ACCOUNT_CONSISTENCY_CONFIRMATION_SYNC_TITLE);
   item.detailText = l10n_util::GetNSString(
       IDS_IOS_ACCOUNT_CONSISTENCY_CONFIRMATION_SYNC_DESCRIPTION);
   item.image = ios::GetChromeBrowserProvider()
                    ->GetBrandedImageProvider()
                    ->GetSigninConfirmationSyncSettingsImage();
   return item;
 }
 
 - (CollectionViewItem*)googleServicesItem {
-  AccountControlItem* item = [[[AccountControlItem alloc]
-      initWithType:ItemTypeGoogleServices] autorelease];
+  AccountControlItem* item =
+      [[AccountControlItem alloc] initWithType:ItemTypeGoogleServices];
   item.text = l10n_util::GetNSString(
       IDS_IOS_ACCOUNT_CONSISTENCY_CONFIRMATION_SERVICES_TITLE);
   item.detailText = l10n_util::GetNSString(
       IDS_IOS_ACCOUNT_CONSISTENCY_CONFIRMATION_SERVICES_DESCRIPTION);
   item.image = ios::GetChromeBrowserProvider()
                    ->GetBrandedImageProvider()
                    ->GetSigninConfirmationPersonalizeServicesImage();
   return item;
 }
 
 - (CollectionViewItem*)openSettingsItem {
-  CollectionViewFooterItem* item = [[[CollectionViewFooterItem alloc]
-      initWithType:ItemTypeFooter] autorelease];
+  CollectionViewFooterItem* item =
+      [[CollectionViewFooterItem alloc] initWithType:ItemTypeFooter];
   item.text = l10n_util::GetNSString(
       IDS_IOS_ACCOUNT_CONSISTENCY_CONFIRMATION_OPEN_SETTINGS);
   item.linkURL = google_util::AppendGoogleLocaleParam(
       GURL("internal://settings-sync"),
       GetApplicationContext()->GetApplicationLocale());
   item.linkDelegate = self;
   return item;
 }
 
 #pragma mark - Helpers
@@ skipping 49 matching lines @@
                                              kTrailingSeparatorInset);
       break;
     case ItemTypeGoogleServices:
       cell.shouldHideSeparator = YES;
       break;
     case ItemTypeFooter: {
       CollectionViewFooterCell* footerCell =
           base::mac::ObjCCastStrict<CollectionViewFooterCell>(cell);
       // TODO(crbug.com/664648): Must use atomic text formatting operation due
       // to LabelLinkController bug.
-      footerCell.textLabel.attributedText = [[[NSAttributedString alloc]
+      footerCell.textLabel.attributedText = [[NSAttributedString alloc]
           initWithString:footerCell.textLabel.text
               attributes:@{
                 NSFontAttributeName : [MDCTypography body1Font],
                 NSForegroundColorAttributeName :
                     [[MDCPalette greyPalette] tint700]
-              }] autorelease];
+              }];
       footerCell.horizontalPadding = 16;
       break;
     }
 
     default:
       break;
   }
   return cell;
 }
 
@@ skipping 21 matching lines @@
   return YES;
 }
 
 #pragma mark - CollectionViewFooterLinkDelegate
 
 - (void)cell:(CollectionViewFooterCell*)cell didTapLinkURL:(GURL)URL {
   [[self delegate] signinConfirmationControllerDidTapSettingsLink:self];
 }
 
 @end