Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2936373002: Revert of media: add video capture device for ARC++ camera HAL v3 (Closed)

Created:
3 years, 6 months ago by findit-for-me
Modified:
3 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, chfremer+watch_chromium.org, chromium-reviews, darin (slow to review), emircan, feature-media-reviews_chromium.org, mcasas, miu+watch_chromium.org, oshima+watch_chromium.org, posciak+watch_chromium.org, Pawel Osciak, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: add video capture device for ARC++ camera HAL v3 (patchset #36 id:700001 of https://codereview.chromium.org/2837273004/ ) Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 479662 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IyYjg0ODAxYmZlODU4YmZlN2U1NjgzNTRjYjNjYTNmMjU3OGU3OGUM Original issue's description: > media: add video capture device for ARC++ camera HAL v3 > > This CL adds VideoCaptureDevice and VideoCaptureDeviceFactory > for the ARC++ camera HAL v3. The VCD and VCD factory talk to > the HAL adapter process on Chrome OS throgh Mojo IPC to access > the camera service. > > BUG=b:32690003 > TEST=Make sure camera preview works in hangout. > TEST=unit tests > > Review-Url: https://codereview.chromium.org/2837273004 > Cr-Commit-Position: refs/heads/master@{#479662} > Committed: https://chromium.googlesource.com/chromium/src/+/b2b84801bfe858bfe7e568354cb3ca3f2578e78e TBR=reveman@chromium.org,chfremer@chromium.org,kenrb@chromium.org,posciak@chromium.org,rockot@chromium.org,wuchengli@chromium.org,yzshen@chromium.org,jcliang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b:32690003 Review-Url: https://codereview.chromium.org/2936373002 Cr-Commit-Position: refs/heads/master@{#479667} Committed: https://chromium.googlesource.com/chromium/src/+/5dc83b132397a2588addef6cc9787747f61a95f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -5504 lines) Patch
M media/capture/BUILD.gn View 2 chunks +1 line, -35 lines 0 comments Download
M media/capture/video/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D media/capture/video/chromeos/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D media/capture/video/chromeos/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D media/capture/video/chromeos/camera_device_context.h View 1 chunk +0 lines, -135 lines 0 comments Download
D media/capture/video/chromeos/camera_device_context.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D media/capture/video/chromeos/camera_device_delegate.h View 1 chunk +0 lines, -173 lines 0 comments Download
D media/capture/video/chromeos/camera_device_delegate.cc View 1 chunk +0 lines, -414 lines 0 comments Download
D media/capture/video/chromeos/camera_device_delegate_unittest.cc View 1 chunk +0 lines, -500 lines 0 comments Download
D media/capture/video/chromeos/camera_hal_delegate.h View 1 chunk +0 lines, -147 lines 0 comments Download
D media/capture/video/chromeos/camera_hal_delegate.cc View 1 chunk +0 lines, -367 lines 0 comments Download
D media/capture/video/chromeos/camera_hal_delegate_unittest.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D media/capture/video/chromeos/camera_metadata_utils.h View 1 chunk +0 lines, -16 lines 0 comments Download
D media/capture/video/chromeos/camera_metadata_utils.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D media/capture/video/chromeos/display_rotation_observer.h View 1 chunk +0 lines, -64 lines 0 comments Download
D media/capture/video/chromeos/display_rotation_observer.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D media/capture/video/chromeos/mock_camera_module.h View 1 chunk +0 lines, -66 lines 0 comments Download
D media/capture/video/chromeos/mock_camera_module.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D media/capture/video/chromeos/mock_video_capture_client.h View 1 chunk +0 lines, -73 lines 0 comments Download
D media/capture/video/chromeos/mock_video_capture_client.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D media/capture/video/chromeos/mojo/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D media/capture/video/chromeos/mojo/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D media/capture/video/chromeos/mojo/arc_camera3.mojom View 1 chunk +0 lines, -310 lines 0 comments Download
D media/capture/video/chromeos/mojo/arc_camera3_metadata.mojom View 1 chunk +0 lines, -40 lines 0 comments Download
D media/capture/video/chromeos/mojo/camera_metadata_tags.mojom View 1 chunk +0 lines, -894 lines 0 comments Download
D media/capture/video/chromeos/pixel_format_utils.h View 1 chunk +0 lines, -23 lines 0 comments Download
D media/capture/video/chromeos/pixel_format_utils.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D media/capture/video/chromeos/stream_buffer_manager.h View 1 chunk +0 lines, -180 lines 0 comments Download
D media/capture/video/chromeos/stream_buffer_manager.cc View 1 chunk +0 lines, -494 lines 0 comments Download
D media/capture/video/chromeos/stream_buffer_manager_unittest.cc View 1 chunk +0 lines, -457 lines 0 comments Download
D media/capture/video/chromeos/video_capture_device_arc_chromeos.h View 1 chunk +0 lines, -90 lines 0 comments Download
D media/capture/video/chromeos/video_capture_device_arc_chromeos.cc View 1 chunk +0 lines, -186 lines 0 comments Download
D media/capture/video/chromeos/video_capture_device_factory_chromeos.h View 1 chunk +0 lines, -61 lines 0 comments Download
D media/capture/video/chromeos/video_capture_device_factory_chromeos.cc View 1 chunk +0 lines, -95 lines 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.h View 3 chunks +4 lines, -5 lines 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M media/capture/video/linux/video_capture_device_factory_linux.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 4 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
findit-for-me
Created Revert of media: add video capture device for ARC++ camera HAL v3
3 years, 6 months ago (2017-06-15 11:15:07 UTC) #1
findit-for-me
Sheriffs, CL owner or CL reviewers: Please confirm and "Quick L-G-T-M & CQ" this revert ...
3 years, 6 months ago (2017-06-15 11:15:09 UTC) #3
jcliang
lgtm lgtm
3 years, 6 months ago (2017-06-15 11:38:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936373002/1
3 years, 6 months ago (2017-06-15 11:38:49 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-15 11:38:51 UTC) #8
Noel Gordon
LGTM
3 years, 6 months ago (2017-06-15 11:52:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2936373002/1
3 years, 6 months ago (2017-06-15 11:53:13 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 11:54:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5dc83b132397a2588addef6cc978...

Powered by Google App Engine
This is Rietveld 408576698