Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: media/capture/video/chromeos/camera_hal_delegate_unittest.cc

Issue 2936373002: Revert of media: add video capture device for ARC++ camera HAL v3 (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/chromeos/camera_hal_delegate_unittest.cc
diff --git a/media/capture/video/chromeos/camera_hal_delegate_unittest.cc b/media/capture/video/chromeos/camera_hal_delegate_unittest.cc
deleted file mode 100644
index 242182bef6a387cb0e0ebde1aa1ae490fd5ab670..0000000000000000000000000000000000000000
--- a/media/capture/video/chromeos/camera_hal_delegate_unittest.cc
+++ /dev/null
@@ -1,158 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "media/capture/video/chromeos/camera_hal_delegate.h"
-
-#include <stddef.h>
-#include <stdint.h>
-
-#include <memory>
-#include <utility>
-
-#include "base/message_loop/message_loop.h"
-#include "base/run_loop.h"
-#include "media/capture/video/chromeos/mock_camera_module.h"
-#include "media/capture/video/chromeos/mojo/arc_camera3.mojom.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using testing::_;
-using testing::A;
-using testing::Invoke;
-
-namespace media {
-
-class CameraHalDelegateTest : public ::testing::Test {
- public:
- CameraHalDelegateTest()
- : message_loop_(new base::MessageLoop),
- hal_delegate_thread_("HalDelegateThread") {}
-
- void SetUp() override {
- hal_delegate_thread_.Start();
- camera_hal_delegate_ =
- new CameraHalDelegate(hal_delegate_thread_.task_runner());
- camera_hal_delegate_->StartForTesting(
- mock_camera_module_.GetInterfacePtrInfo());
- }
-
- void TearDown() override {
- camera_hal_delegate_->Reset();
- hal_delegate_thread_.Stop();
- }
-
- void Wait() {
- run_loop_.reset(new base::RunLoop());
- run_loop_->Run();
- }
-
- protected:
- scoped_refptr<CameraHalDelegate> camera_hal_delegate_;
- testing::StrictMock<unittest_internal::MockCameraModule> mock_camera_module_;
-
- private:
- std::unique_ptr<base::MessageLoop> message_loop_;
- base::Thread hal_delegate_thread_;
- std::unique_ptr<base::RunLoop> run_loop_;
- DISALLOW_COPY_AND_ASSIGN(CameraHalDelegateTest);
-};
-
-TEST_F(CameraHalDelegateTest, GetBuiltinCameraInfo) {
- auto get_number_of_cameras_cb =
- [](arc::mojom::CameraModule::GetNumberOfCamerasCallback& cb) {
- std::move(cb).Run(2);
- };
-
- auto get_camera_info_cb = [](uint32_t camera_id,
- arc::mojom::CameraModule::GetCameraInfoCallback&
- cb) {
- arc::mojom::CameraInfoPtr camera_info = arc::mojom::CameraInfo::New();
- arc::mojom::CameraMetadataPtr static_metadata =
- arc::mojom::CameraMetadata::New();
- static_metadata->entry_count = 1;
- static_metadata->entry_capacity = 1;
- static_metadata->entries =
- std::vector<arc::mojom::CameraMetadataEntryPtr>();
-
- arc::mojom::CameraMetadataEntryPtr entry =
- arc::mojom::CameraMetadataEntry::New();
- entry->index = 0;
- entry->tag = arc::mojom::CameraMetadataTag::
- ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS;
- entry->type = arc::mojom::EntryType::TYPE_INT64;
- entry->count = 8;
- std::vector<int64_t> min_frame_durations(8);
- min_frame_durations[0] = static_cast<int64_t>(
- arc::mojom::HalPixelFormat::HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED);
- min_frame_durations[1] = 1280;
- min_frame_durations[2] = 720;
- min_frame_durations[3] = 33333333;
- min_frame_durations[4] = static_cast<int64_t>(
- arc::mojom::HalPixelFormat::HAL_PIXEL_FORMAT_YCbCr_420_888);
- min_frame_durations[5] = 1280;
- min_frame_durations[6] = 720;
- min_frame_durations[7] = 16666666;
- uint8_t* as_int8 = reinterpret_cast<uint8_t*>(min_frame_durations.data());
- entry->data.assign(as_int8, as_int8 + entry->count * sizeof(int64_t));
- static_metadata->entries->push_back(std::move(entry));
-
- switch (camera_id) {
- case 0:
- camera_info->facing = arc::mojom::CameraFacing::CAMERA_FACING_BACK;
- camera_info->orientation = 0;
- camera_info->static_camera_characteristics = std::move(static_metadata);
- break;
- case 1:
- camera_info->facing = arc::mojom::CameraFacing::CAMERA_FACING_FRONT;
- camera_info->orientation = 0;
- camera_info->static_camera_characteristics = std::move(static_metadata);
- break;
- default:
- FAIL() << "Invalid camera id";
- }
- std::move(cb).Run(0, std::move(camera_info));
- };
-
- EXPECT_CALL(mock_camera_module_, DoGetNumberOfCameras(_))
- .Times(1)
- .WillOnce(Invoke(get_number_of_cameras_cb));
- EXPECT_CALL(
- mock_camera_module_,
- DoSetCallbacks(A<arc::mojom::CameraModuleCallbacksPtr&>(),
- A<arc::mojom::CameraModule::SetCallbacksCallback&>()))
- .Times(1);
- EXPECT_CALL(
- mock_camera_module_,
- DoGetCameraInfo(0, A<arc::mojom::CameraModule::GetCameraInfoCallback&>()))
- .Times(1)
- .WillOnce(Invoke(get_camera_info_cb));
- EXPECT_CALL(
- mock_camera_module_,
- DoGetCameraInfo(1, A<arc::mojom::CameraModule::GetCameraInfoCallback&>()))
- .Times(1)
- .WillOnce(Invoke(get_camera_info_cb));
-
- VideoCaptureDeviceDescriptors descriptors;
- camera_hal_delegate_->GetDeviceDescriptors(&descriptors);
-
- ASSERT_EQ(2U, descriptors.size());
- // We have workaround to always put front camera at first.
- ASSERT_EQ(std::to_string(1), descriptors[0].device_id);
- ASSERT_EQ(VideoFacingMode::MEDIA_VIDEO_FACING_USER, descriptors[0].facing);
- ASSERT_EQ(std::to_string(0), descriptors[1].device_id);
- ASSERT_EQ(VideoFacingMode::MEDIA_VIDEO_FACING_ENVIRONMENT,
- descriptors[1].facing);
-
- VideoCaptureFormats supported_formats;
- camera_hal_delegate_->GetSupportedFormats(descriptors[0], &supported_formats);
-
- // IMPLEMENTATION_DEFINED format should be filtered; currently YCbCr_420_888
- // format corresponds to NV12 in Chrome.
- ASSERT_EQ(1U, supported_formats.size());
- ASSERT_EQ(gfx::Size(1280, 720), supported_formats[0].frame_size);
- ASSERT_FLOAT_EQ(60.0, supported_formats[0].frame_rate);
- ASSERT_EQ(PIXEL_FORMAT_NV12, supported_formats[0].pixel_format);
-}
-
-} // namespace media
« no previous file with comments | « media/capture/video/chromeos/camera_hal_delegate.cc ('k') | media/capture/video/chromeos/camera_metadata_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698