Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2935933007: Delete class DirectoryIterator and FileRotatingStream read support. (Closed)

Created:
1 year, 1 month ago by nisse-webrtc
Modified:
9 months, 2 weeks ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete class DirectoryIterator and FileRotatingStream read support. This is an exploratory cl, to find out what breaks when these features are removed. BUG=webrtc:7812, webrtc:6424

Patch Set 1 #

Patch Set 2 : Delete java getLogData for now. Fix windows problem. #

Patch Set 3 : #if out objc logData method. #

Patch Set 4 : Drop an RTC_NOTREACHED. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -384 lines) Patch
M webrtc/base/filerotatingstream.h View 3 chunks +0 lines, -12 lines 0 comments Download
M webrtc/base/filerotatingstream.cc View 8 chunks +21 lines, -160 lines 0 comments Download
M webrtc/base/filerotatingstream_unittest.cc View 1 2 3 6 chunks +108 lines, -42 lines 0 comments Download
M webrtc/base/fileutils.h View 1 chunk +0 lines, -45 lines 0 comments Download
M webrtc/base/fileutils.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M webrtc/base/unixfilesystem.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/win32filesystem.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/android/api/org/webrtc/CallSessionFileRotatingLogSink.java View 1 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/sdk/android/src/jni/peerconnection_jni.cc View 1 1 chunk +0 lines, -27 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/Common/RTCFileLogger.mm View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFileLogger.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nisse-webrtc
PTAL. I think both the android and the objc apis need a method to read ...
1 year, 1 month ago (2017-06-14 09:08:27 UTC) #2
nisse-webrtc
On 2017/06/14 09:08:27, nisse-webrtc wrote: > PTAL. I think both the android and the objc ...
1 year, 1 month ago (2017-06-14 11:46:04 UTC) #3
nisse-webrtc
9 months, 2 weeks ago (2017-09-29 12:58:59 UTC) #4
On 2017/06/14 11:46:04, nisse-webrtc wrote:
> On 2017/06/14 09:08:27, nisse-webrtc wrote:
> > PTAL. I think both the android and the objc apis need a method to read the
log
> > files, so that needs to be rewritten. If we really want to do it in C++ and
> > avoid code duplication, we could add something minimal based on the
> > ReadLogDirectory function I have in the test.
> 
> And the linux_internal failures look as could be expected.

Moved to gerrit, cl https://webrtc-review.googlesource.com/c/src/+/4821

Powered by Google App Engine
This is Rietveld 408576698