Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: webrtc/sdk/android/api/org/webrtc/CallSessionFileRotatingLogSink.java

Issue 2935933007: Delete class DirectoryIterator and FileRotatingStream read support. (Closed)
Patch Set: Drop an RTC_NOTREACHED. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/win32filesystem.cc ('k') | webrtc/sdk/android/src/jni/peerconnection_jni.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/android/api/org/webrtc/CallSessionFileRotatingLogSink.java
diff --git a/webrtc/sdk/android/api/org/webrtc/CallSessionFileRotatingLogSink.java b/webrtc/sdk/android/api/org/webrtc/CallSessionFileRotatingLogSink.java
index 9b53ce4873946093f0d510ba7be76384e1e8d48d..49f238b61fc7f293716040c98a733d4a613e1605 100644
--- a/webrtc/sdk/android/api/org/webrtc/CallSessionFileRotatingLogSink.java
+++ b/webrtc/sdk/android/api/org/webrtc/CallSessionFileRotatingLogSink.java
@@ -17,10 +17,11 @@ public class CallSessionFileRotatingLogSink {
private long nativeSink;
- public static byte[] getLogData(String dirPath) {
- return nativeGetLogData(dirPath);
- }
-
+ /* TODO(nisse): Reimplement in plain java.
+ public static byte[] getLogData(String dirPath) {
+ return nativeGetLogData(dirPath);
+ }
+ */
public CallSessionFileRotatingLogSink(
String dirPath, int maxFileSize, Logging.Severity severity) {
nativeSink = nativeAddSink(dirPath, maxFileSize, severity.ordinal());
@@ -35,5 +36,4 @@ public class CallSessionFileRotatingLogSink {
private static native long nativeAddSink(String dirPath, int maxFileSize, int severity);
private static native void nativeDeleteSink(long nativeSink);
- private static native byte[] nativeGetLogData(String dirPath);
}
« no previous file with comments | « webrtc/base/win32filesystem.cc ('k') | webrtc/sdk/android/src/jni/peerconnection_jni.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698