Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2935713002: [ObjC ARC] Converts ios/chrome/app:unit_tests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
gambard, stkhapugin
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/app:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2935713002 Cr-Commit-Position: refs/heads/master@{#478676} Committed: https://chromium.googlesource.com/chromium/src/+/528c7c50c9e45cdff5bcbc192d0c341ffac56ce7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed spurious include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -65 lines) Patch
M ios/chrome/app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/app/chrome_app_startup_parameters_unittest.mm View 11 chunks +50 lines, -53 lines 0 comments Download
M ios/chrome/app/deferred_initialization_runner_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/app/main_application_delegate_unittest.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/app/main_controller_unittest.mm View 1 4 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 14:40:41 UTC) #6
gambard
lgtm with one comment https://codereview.chromium.org/2935713002/diff/1/ios/chrome/app/main_controller_unittest.mm File ios/chrome/app/main_controller_unittest.mm (right): https://codereview.chromium.org/2935713002/diff/1/ios/chrome/app/main_controller_unittest.mm#newcode7 ios/chrome/app/main_controller_unittest.mm:7: #import "base/mac/bind_objc_block.h" Is this still ...
3 years, 6 months ago (2017-06-12 14:50:48 UTC) #7
marq (ping after 24h)
Thanks for the review! https://codereview.chromium.org/2935713002/diff/1/ios/chrome/app/main_controller_unittest.mm File ios/chrome/app/main_controller_unittest.mm (right): https://codereview.chromium.org/2935713002/diff/1/ios/chrome/app/main_controller_unittest.mm#newcode7 ios/chrome/app/main_controller_unittest.mm:7: #import "base/mac/bind_objc_block.h" On 2017/06/12 14:50:48, ...
3 years, 6 months ago (2017-06-12 16:33:16 UTC) #8
marq (ping after 24h)
Removed spurious include.
3 years, 6 months ago (2017-06-12 16:34:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935713002/20001
3 years, 6 months ago (2017-06-12 16:35:12 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 18:00:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/528c7c50c9e45cdff5bcbc192d0c...

Powered by Google App Engine
This is Rietveld 408576698