[ObjC ARC] Converts ios/chrome/app:unit_tests to ARC.

ios/chrome/app/main_controller_unittest.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Foundation/Foundation.h>
 
 #import "base/mac/bind_objc_block.h"

[gambard, 2017/06/12 14:50:48]

Is this still needed?

[marq (ping after 24h), 2017/06/12 16:33:15]

Nope, good catch.

 #include "base/threading/thread.h"
 #import "ios/chrome/app/application_delegate/app_state.h"
 #import "ios/chrome/app/application_delegate/url_opener.h"
 #include "ios/chrome/app/main_controller_private.h"
 #import "ios/chrome/browser/tabs/tab_model.h"
 #import "ios/chrome/test/base/scoped_block_swizzler.h"
 #include "testing/platform_test.h"
 #import "third_party/ocmock/OCMock/OCMock.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 #pragma mark - MainController Testing Additions
 
 @interface MainController (TestingAdditions)
 - (id)initForTesting;
 @end
 
 @implementation MainController (TestingAdditions)
 - (id)initForTesting {
   self = [self init];
   if (self) {
@@ skipping 26 matching lines @@
 
 class TabOpenerTest : public PlatformTest {
  protected:
   BOOL swizzleHasBeenCalled() { return swizzle_block_executed_; }
 
   void swizzleHandleLaunchOptions(
       NSDictionary* expectedLaunchOptions,
       id<StartupInformation> expectedStartupInformation,
       AppState* expectedAppState) {
     swizzle_block_executed_ = NO;
-    swizzle_block_.reset(
+    swizzle_block_ =
         [^(id self, NSDictionary* options, BOOL applicationActive,
            id<TabOpening> tabOpener, id<StartupInformation> startupInformation,
            AppState* appState) {
           swizzle_block_executed_ = YES;
           EXPECT_EQ(expectedLaunchOptions, options);
           EXPECT_EQ(expectedStartupInformation, startupInformation);
-          EXPECT_EQ(main_controller_.get(), tabOpener);
+          EXPECT_EQ(main_controller_, tabOpener);
           EXPECT_EQ(expectedAppState, appState);
-        } copy]);
+        } copy];
     URL_opening_handle_launch_swizzler_.reset(new ScopedBlockSwizzler(
         [URLOpener class], @selector(handleLaunchOptions:
                                        applicationActive:
                                                tabOpener:
                                       startupInformation:
                                                 appState:),
         swizzle_block_));
   }
 
   MainController* GetMainController() {
-    if (!main_controller_.get()) {
-      main_controller_.reset([[MainController alloc] initForTesting]);
+    if (!main_controller_) {
+      main_controller_ = [[MainController alloc] initForTesting];
     }
-    return main_controller_.get();
+    return main_controller_;
   }
 
  private:
-  base::scoped_nsobject<MainController> main_controller_;
+  MainController* main_controller_;
   __block BOOL swizzle_block_executed_;
-  base::mac::ScopedBlock<HandleLaunchOptions> swizzle_block_;
+  HandleLaunchOptions swizzle_block_;
   std::unique_ptr<ScopedBlockSwizzler> URL_opening_handle_launch_swizzler_;
 };
 
 #pragma mark - Tests.
 
 // Tests that -newTabFromLaunchOptions calls +handleLaunchOption and reset
 // options.
 TEST_F(TabOpenerTest, openTabFromLaunchOptionsWithOptions) {
   // Setup.
   NSString* sourceApplication = @"com.apple.mobilesafari";
@@ skipping 31 matching lines @@
 
   // Action.
   [tabOpener openTabFromLaunchOptions:nil
                    startupInformation:startupInformationMock
                              appState:appStateMock];
 
   // Test.
   EXPECT_FALSE(swizzleHasBeenCalled());
 }
 }  // namespace