Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2935563002: input: Remove dead code. (Closed)

Created:
3 years, 6 months ago by sadrul
Modified:
3 years, 6 months ago
Reviewers:
dtapuska, jam
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

input: Remove dead code. Synthesized input events for telemetry tests are no longer triggered on a begin frame (after crrev.com/475692). So remove the now-unused code for requesting a begin frame for dispatching synthesized input events. BUG=722921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2935563002 Cr-Commit-Position: refs/heads/master@{#479326} Committed: https://chromium.googlesource.com/chromium/src/+/110abc75b89d7c3b499454df9c70cbfaff3a316a

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -89 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 3 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +1 line, -16 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 3 chunks +1 line, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 3 chunks +1 line, -10 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 29 (19 generated)
sadrul
3 years, 6 months ago (2017-06-10 18:40:02 UTC) #12
dtapuska
On 2017/06/10 18:40:02, sadrul wrote: lgtm
3 years, 6 months ago (2017-06-12 13:44:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935563002/20001
3 years, 6 months ago (2017-06-12 17:05:38 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/461400)
3 years, 6 months ago (2017-06-12 17:17:07 UTC) #17
sadrul
+jam@ for content owner stamp.
3 years, 6 months ago (2017-06-12 21:42:24 UTC) #19
jam
lgtm
3 years, 6 months ago (2017-06-13 17:53:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935563002/20001
3 years, 6 months ago (2017-06-14 03:18:05 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/317123)
3 years, 6 months ago (2017-06-14 04:15:36 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935563002/20001
3 years, 6 months ago (2017-06-14 07:36:43 UTC) #26
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 08:22:46 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/110abc75b89d7c3b499454df9c70...

Powered by Google App Engine
This is Rietveld 408576698