Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2935563002: input: Remove dead code. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 492526c27c3c8fb82fad33d7a7fbaf68178ddf92..1e60cc18ce74d0bad365c30d147d877e937ad34e 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -1739,11 +1739,6 @@ InputEventAckState RenderWidgetHostViewAndroid::FilterInputEvent(
return INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
}
-void RenderWidgetHostViewAndroid::OnSetNeedsFlushInput() {
- TRACE_EVENT0("input", "RenderWidgetHostViewAndroid::OnSetNeedsFlushInput");
- AddBeginFrameRequest(FLUSH_INPUT);
-}
-
BrowserAccessibilityManager*
RenderWidgetHostViewAndroid::CreateBrowserAccessibilityManager(
BrowserAccessibilityDelegate* delegate, bool for_root_frame) {
@@ -2139,19 +2134,9 @@ void RenderWidgetHostViewAndroid::OnBeginFrame(const cc::BeginFrameArgs& args) {
// Update |last_begin_frame_args_| before handling
// |outstanding_begin_frame_requests_| to prevent the BeginFrameSource from
- // sending the same MISSED args in infinite recursion. This may otherwise
- // happen if |host_->OnBeginFrame()| causes a synchronous
- // OnSetNeedsFlushInput() which can lead to
- // |begin_frame_source_->AddObserver()| and OnBeginFrame(). By setting
- // |last_begin_frame_args_|, we indicate to the source not to send the same
- // args during |AddObserver()| again.
+ // sending the same MISSED args in infinite recursion.
last_begin_frame_args_ = args;
- if (outstanding_begin_frame_requests_ & FLUSH_INPUT) {
- ClearBeginFrameRequest(FLUSH_INPUT);
- host_->OnBeginFrame();
- }
-
if ((outstanding_begin_frame_requests_ & BEGIN_FRAME) ||
(outstanding_begin_frame_requests_ & PERSISTENT_BEGIN_FRAME)) {
ClearBeginFrameRequest(BEGIN_FRAME);

Powered by Google App Engine
This is Rietveld 408576698