Break up chrome/common:common: safe_browsing

Break up chrome/common:common: safe_browsing

This CL breaks off some targets from chrome/common:common.

Context: https://crrev.com/2850863002 introduced a binary size
regression. In order to address it, chrome_logging.* needs to be
pulled out from chrome/common:common to a separate target, but
this turns out to be hard. This CL is a stepping stone.

BUG=717103
Review-Url: https://codereview.chromium.org/2935383003
Cr-Commit-Position: refs/heads/master@{#481204}
Committed: https://chromium.googlesource.com/chromium/src/+/55aebefd499df868e163541642068290cf2eea11

[manzagop (departed), 2017-06-15 21:45:15]

manzagop@chromium.org changed reviewers:
+ agrieve@chromium.org

[manzagop (departed), 2017-06-15 21:45:15]

Hi Andrew,

Here is a third. Getting there. Slowly. 

Thanks!

P-A

[agrieve, 2017-06-16 01:11:14]

On 2017/06/15 21:45:15, manzagop wrote:
> Hi Andrew,
> 
> Here is a third. Getting there. Slowly. 
> 
> Thanks!
> 
> P-A

lgtm

[manzagop (departed), 2017-06-16 14:44:05]

manzagop@chromium.org changed reviewers:
+ vakh@chromium.org

[manzagop (departed), 2017-06-16 14:44:11]

Hi Varun,

Could you have an owners' look for chrome/common/safe_browsing? 

Thanks,

Pierre-Antoine

[manzagop (departed), 2017-06-16 18:45:03]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 18:45:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 18:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 18:55:29]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[manzagop (departed), 2017-06-16 19:12:30]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 19:12:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 19:25:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 19:25:39]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[vakh (use Gerrit instead), 2017-06-16 20:05:45]

lgtm

[manzagop (departed), 2017-06-16 21:24:17]

Thank you for the reviews!

[manzagop (departed), 2017-06-16 21:24:23]

The CQ bit was checked by manzagop@chromium.org

[manzagop (departed), 2017-06-16 21:24:23]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2935383003/#ps60001
(title: "fixups")

[commit-bot: I haz the power, 2017-06-16 21:24:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 21:34:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 21:34:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[manzagop (departed), 2017-06-16 21:43:07]

manzagop@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, thakis@chromium.org

[manzagop (departed), 2017-06-16 21:43:08]

Hi Nico, Devlin,

Could you have an owners' look?

Nico: chrome\utility\BUILD.gn 
Devlin: chrome\browser\extensions\BUILD.gn

Thanks!

Pierre-Antoine

[Devlin, 2017-06-16 22:20:19]

On 2017/06/16 21:43:08, manzagop wrote:
> Could you have an owners' look?
> Devlin: chrome\browser\extensions\BUILD.gn

chrome\browser\extensions\BUILD.gn lgtm

[manzagop (departed), 2017-06-19 14:43:22]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 14:43:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 16:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 16:06:41]

Dry run: This issue passed the CQ dry run.

[manzagop (departed), 2017-06-20 15:56:49]

Thanks Devlin! 

Friendly ping Nico. :)

[Nico, 2017-06-20 17:42:56]

lgtm

[manzagop (departed), 2017-06-20 18:29:39]

Thanks for the reviews!

[manzagop (departed), 2017-06-20 18:29:49]

The CQ bit was checked by manzagop@chromium.org

[manzagop (departed), 2017-06-20 18:29:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, vakh@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2935383003/#ps80001
(title: "merge")

[commit-bot: I haz the power, 2017-06-20 18:30:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 19:44:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 19:44:47]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[manzagop (departed), 2017-06-21 13:39:45]

The CQ bit was checked by manzagop@chromium.org

[commit-bot: I haz the power, 2017-06-21 13:39:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 14:38:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498052385556670,
"parent_rev": "1a45c520cc585fa6b1756e7a337aca38f70485f1", "commit_rev":
"55aebefd499df868e163541642068290cf2eea11"}

[commit-bot: I haz the power, 2017-06-21 14:39:03]

Description was changed from

==========
Break up chrome/common:common: safe_browsing

This CL breaks off some targets from chrome/common:common.

Context: https://crrev.com/2850863002 introduced a binary size
regression. In order to address it, chrome_logging.* needs to be
pulled out from chrome/common:common to a separate target, but
this turns out to be hard. This CL is a stepping stone.

BUG=717103
==========

to

==========
Break up chrome/common:common: safe_browsing

This CL breaks off some targets from chrome/common:common.

Context: https://crrev.com/2850863002 introduced a binary size
regression. In order to address it, chrome_logging.* needs to be
pulled out from chrome/common:common to a separate target, but
this turns out to be hard. This CL is a stepping stone.

BUG=717103

Review-Url: https://codereview.chromium.org/2935383003
Cr-Commit-Position: refs/heads/master@{#481204}
Committed:
https://chromium.googlesource.com/chromium/src/+/55aebefd499df868e16354164206...
==========

[commit-bot: I haz the power, 2017-06-21 14:39:04]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/55aebefd499df868e16354164206...