[CRD iOS] Define template for the CRD iOS target

[CRD iOS] Define template for the CRD iOS target

This CL adds a template for building CRD iOS target so that we can easily
implement the production target by adding new sources or deps.

Eventually logic for authentication and settings menu will be moved out of the
template.

BUG=731851
Review-Url: https://codereview.chromium.org/2934593002
Cr-Commit-Position: refs/heads/master@{#478788}
Committed: https://chromium.googlesource.com/chromium/src/+/aed90520db4cc2f26e784ba2d61d35f48cfb595a

[Yuwei, 2017-06-09 19:52:39]

yuweih@chromium.org changed reviewers:
+ nicholss@chromium.org

[Yuwei, 2017-06-09 19:52:39]

PTAL thanks!

[Yuwei, 2017-06-09 19:52:49]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 19:53:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nicholss, 2017-06-09 21:36:47]

On 2017/06/09 19:52:39, Yuwei wrote:
> PTAL thanks!

Is there another example of this done somewhere? It seems strange, how does
overwriting work with this scheme?

[nicholss, 2017-06-09 21:36:54]

https://codereview.chromium.org/2934593002/diff/20001/remoting/ios/app/remoti...
File remoting/ios/app/remoting_ios_tmpl.gni (right):

https://codereview.chromium.org/2934593002/diff/20001/remoting/ios/app/remoti...
remoting/ios/app/remoting_ios_tmpl.gni:78: # TODO(yuweih): Need different launch
screen for official build?
The launch screens stays the same and the images included in the build should
change.

[Yuwei, 2017-06-09 21:53:19]

This is similar to how we do it for the Android client. You can see this:
https://cs.chromium.org/chromium/src/remoting/android/remoting_apk_tmpl.gni

and also client_java_tmpl.gni

The template just defines common sources and deps, so it's not like overwriting.

Eventually it will be something like:
external:
  sources = ["external/initializer.mm", "external/autenticator.h", ...]
internal:
  sources = ["internal/initializer.mm", "internal/authenticator.h", ...]

I'm not sure how Chrome deals with that though...

https://codereview.chromium.org/2934593002/diff/20001/remoting/ios/app/remoti...
File remoting/ios/app/remoting_ios_tmpl.gni (right):

https://codereview.chromium.org/2934593002/diff/20001/remoting/ios/app/remoti...
remoting/ios/app/remoting_ios_tmpl.gni:78: # TODO(yuweih): Need different launch
screen for official build?
On 2017/06/09 21:36:54, nicholss wrote:
> The launch screens stays the same and the images included in the build should
> change.

Okay... Removed it for now.

[Yuwei, 2017-06-09 23:34:53]

PTAL thanks!

As discussed offline, it's much easier to branch on main/AppDelegate.

The internal app can simply provide a different main function and initialize a
subclass of AppDelegate and store the resources there.

The macro definition approach I talked about probably doesn't work because the
subclassed app delegate is not in the common source set...

[nicholss, 2017-06-12 17:45:27]

lgtm 

That looks nice now, thanks!!

[Yuwei, 2017-06-12 19:06:46]

Thanks! Checking-in

[Yuwei, 2017-06-12 19:06:50]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2017-06-12 19:07:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 20:01:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:01:32]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuwei, 2017-06-12 20:15:45]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:16:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuwei, 2017-06-12 21:39:09]

The CQ bit was unchecked by yuweih@chromium.org

[Yuwei, 2017-06-12 21:39:31]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2017-06-12 21:39:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 22:12:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497303571340310,
"parent_rev": "a34648550e4e95f355854e937c0cb1a095833681", "commit_rev":
"aed90520db4cc2f26e784ba2d61d35f48cfb595a"}

[commit-bot: I haz the power, 2017-06-12 22:13:10]

Description was changed from

==========
[CRD iOS] Define template for the CRD iOS target

This CL adds a template for building CRD iOS target so that we can easily
implement the production target by adding new sources or deps.

Eventually logic for authentication and settings menu will be moved out of the
template.

BUG=731851
==========

to

==========
[CRD iOS] Define template for the CRD iOS target

This CL adds a template for building CRD iOS target so that we can easily
implement the production target by adding new sources or deps.

Eventually logic for authentication and settings menu will be moved out of the
template.

BUG=731851

Review-Url: https://codereview.chromium.org/2934593002
Cr-Commit-Position: refs/heads/master@{#478788}
Committed:
https://chromium.googlesource.com/chromium/src/+/aed90520db4cc2f26e784ba2d61d...
==========

[commit-bot: I haz the power, 2017-06-12 22:13:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/aed90520db4cc2f26e784ba2d61d...