chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc - Issue 2934543002: Sending a page load pingback to data saver for holdback users

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

Issue 2934543002: Sending a page load pingback to data saver for holdback users (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc » ('j') | components/data_reduction_proxy/proto/pageload_metrics.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

index 5e05b1b122ff8f69e914298526bf21326d8853f9..0cf755f12747fd71119367994832788571f676b3 100644

--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

@@ -278,8 +278,7 @@ void DataReductionProxyMetricsObserver::SendPingback(

// shutdown cases. crbug.com/618072

if (!browser_context_ || !data_)

return;

- if (data_reduction_proxy::params::IsIncludedInHoldbackFieldTrial() ||

- data_reduction_proxy::params::IsIncludedInTamperDetectionExperiment()) {

+ if (data_reduction_proxy::params::IsIncludedInTamperDetectionExperiment()) {

buettner 2017/06/09 17:20:35 We turned down tamper detection on the server long

tbansal1 2017/06/09 17:32:29 https://bugs.chromium.org/p/chromium/issues/detail

RyanSturm 2017/06/09 19:40:19 Done.

return;

}

// Only consider timing events that happened before the first background

tbansal1 2017/06/09 17:32:29 unrelated but can we add a DCHECK that url() is ht

RyanSturm 2017/06/09 19:40:19 Added one above for checking something related.