Sending a page load pingback to data saver for holdback users

chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h"
 
 #include <string>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/optional.h"
@@ skipping 260 matching lines @@
 }
 
 void DataReductionProxyMetricsObserver::SendPingback(
     const page_load_metrics::mojom::PageLoadTiming& timing,
     const page_load_metrics::PageLoadExtraInfo& info,
     bool app_background_occurred) {
   // TODO(ryansturm): Move to OnFirstBackgroundEvent to handle some fast
   // shutdown cases. crbug.com/618072
   if (!browser_context_ || !data_)
     return;
-  if (data_reduction_proxy::params::IsIncludedInHoldbackFieldTrial() ||
-      data_reduction_proxy::params::IsIncludedInTamperDetectionExperiment()) {
+  if (data_reduction_proxy::params::IsIncludedInTamperDetectionExperiment()) {

[buettner, 2017/06/09 17:20:35]

We turned down tamper detection on the server long ago. Regardless, I'm not sure
why we'd gate PLM reports based on the tamper detection experiment.

[tbansal1, 2017/06/09 17:32:29]

https://bugs.chromium.org/p/chromium/issues/detail?id=675761 is for cleaning up
the code.

[RyanSturm, 2017/06/09 19:40:19]

Done.

     return;
   }
   // Only consider timing events that happened before the first background

[tbansal1, 2017/06/09 17:32:29]

unrelated but can we add a DCHECK that url() is http, not https.

[RyanSturm, 2017/06/09 19:40:19]

Added one above for checking something related.

   // event.
   base::Optional<base::TimeDelta> response_start;
   base::Optional<base::TimeDelta> load_event_start;
   base::Optional<base::TimeDelta> first_image_paint;
   base::Optional<base::TimeDelta> first_contentful_paint;
   base::Optional<base::TimeDelta> experimental_first_meaningful_paint;
   base::Optional<base::TimeDelta> parse_blocked_on_script_load_duration;
   base::Optional<base::TimeDelta> parse_stop;
   if (WasStartedInForegroundOptionalEventInForeground(timing.response_start,
                                                       info)) {
@@ skipping 148 matching lines @@
 
 DataReductionProxyPingbackClient*
 DataReductionProxyMetricsObserver::GetPingbackClient() const {
   return DataReductionProxyChromeSettingsFactory::GetForBrowserContext(
              browser_context_)
       ->data_reduction_proxy_service()
       ->pingback_client();
 }
 
 }  // namespace data_reduction_proxy