Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc

Issue 2934543002: Sending a page load pingback to data saver for holdback users (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
index ac083d02c24a86acfa58bc113245dd2372898bc8..4aeae4bb1ba00e599214fedc95ea3f52af0795eb 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
@@ -443,12 +443,12 @@ TEST_F(DataReductionProxyMetricsObserverTest, OnCompletePingback) {
EXPECT_FALSE(pingback_client_->send_pingback_called());
ResetTest();
- // Verify that when the holdback experiment is enabled, no pingback is sent.
+ // Verify that when the holdback experiment is enabled, a pingback is sent.
base::FieldTrialList field_trial_list(nullptr);
ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
"DataCompressionProxyHoldback", "Enabled"));
RunTestAndNavigateToUntrackedUrl(true, false);
- EXPECT_FALSE(pingback_client_->send_pingback_called());
+ EXPECT_TRUE(pingback_client_->send_pingback_called());
}
TEST_F(DataReductionProxyMetricsObserverTest, ByteInformationCompression) {

Powered by Google App Engine
This is Rietveld 408576698