Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2934493002: Fix SSL indicator missing when doing fast back/forward navigations. (Closed)

Created:
3 years, 6 months ago by jam
Modified:
3 years, 6 months ago
Reviewers:
estark
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Fix SSL indicator missing when doing fast back/forward navigations. This regressed in r415977, which was fixing the session restore case where a serialized NavigationEntry wouldn't have the SSLStatus. The race in the non-restore case happens because a previous DidStopLoading IPC clears the new NavigationHandle which does have the SSLStatus. In this case, the fix is to only copy the SSLStatus specifically in the restore case. BUG=727892 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation R=estark@chromium.org Review-Url: https://codereview.chromium.org/2926803002 . Cr-Original-Commit-Position: refs/heads/master@{#477837} Review-Url: https://codereview.chromium.org/2934493002 . Cr-Commit-Position: refs/branch-heads/3112@{#282} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/c89b46b3ed1f0f084ff3213750c688c8154e62a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
jam
3 years, 6 months ago (2017-06-09 15:50:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c89b46b3ed1f0f084ff3213750c688c8154e62a5.

Powered by Google App Engine
This is Rietveld 408576698