Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2934493002: Fix SSL indicator missing when doing fast back/forward navigations. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index c133a633181190a019af936a93be4a607c757ae6..1f07ec664e0b2f0f212e746e2fb5d89d9d80db42 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -1297,7 +1297,10 @@ void NavigationControllerImpl::RendererDidNavigateToExistingPage(
} else {
// When restoring a tab, the serialized NavigationEntry doesn't have the
// SSL state.
- entry->GetSSL() = handle->ssl_status();
+ // Only copy in the restore case since this code path can be taken during
+ // navigation. See http://crbug.com/727892
+ if (was_restored)
+ entry->GetSSL() = handle->ssl_status();
}
} else {
// This is renderer-initiated. The only kinds of renderer-initated
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698