Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2934053002: Revert of [ObjC ARC] Converts ios/web:ios_web_inttests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts ios/web:ios_web_inttests to ARC. (patchset #1 id:1 of https://codereview.chromium.org/2935683002/ ) Reason for revert: Breaks tree? Original issue's description: > [ObjC ARC] Converts ios/web:ios_web_inttests to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Review-Url: https://codereview.chromium.org/2935683002 > Cr-Commit-Position: refs/heads/master@{#478635} > Committed: https://chromium.googlesource.com/chromium/src/+/dac067a438e47907c38ea2093083f8e7678477b8 TBR=stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624363 Review-Url: https://codereview.chromium.org/2934053002 Cr-Commit-Position: refs/heads/master@{#478952} Committed: https://chromium.googlesource.com/chromium/src/+/08012dc3513eaf24a8d44e5cd63add938ddd41e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ios/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/browser_state_web_view_partition_inttest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/navigation_callbacks_inttest.mm View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
marq (ping after 24h)
Created Revert of [ObjC ARC] Converts ios/web:ios_web_inttests to ARC.
3 years, 6 months ago (2017-06-13 09:50:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2934053002/1
3 years, 6 months ago (2017-06-13 09:50:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/08012dc3513eaf24a8d44e5cd63add938ddd41e6
3 years, 6 months ago (2017-06-13 09:50:57 UTC) #6
stkhapugin
3 years, 6 months ago (2017-06-13 11:03:58 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698