Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 2935683002: [ObjC ARC] Converts ios/web:ios_web_inttests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web:ios_web_inttests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2935683002 Cr-Commit-Position: refs/heads/master@{#478635} Committed: https://chromium.googlesource.com/chromium/src/+/dac067a438e47907c38ea2093083f8e7678477b8

Patch Set 1 #

Patch Set 2 : [ObjC ARC] Converts ios/web:ios_web_inttests to ARC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ios/web/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/browser_state_web_view_partition_inttest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/navigation_callbacks_inttest.mm View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 13:28:52 UTC) #6
stkhapugin
lgtm
3 years, 6 months ago (2017-06-12 15:36:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935683002/1
3 years, 6 months ago (2017-06-12 15:36:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/dac067a438e47907c38ea2093083f8e7678477b8
3 years, 6 months ago (2017-06-12 15:42:35 UTC) #12
stkhapugin
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2935023002/ by stkhapugin@chromium.org. ...
3 years, 6 months ago (2017-06-13 09:50:02 UTC) #13
marq (ping after 24h)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2934053002/ by marq@chromium.org. ...
3 years, 6 months ago (2017-06-13 09:50:02 UTC) #14
marq (ping after 24h)
3 years, 6 months ago (2017-06-15 09:48:58 UTC) #15
Message was sent while issue was closed.
[ObjC ARC] Converts ios/web:ios_web_inttests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Powered by Google App Engine
This is Rietveld 408576698