chrome/browser/plugins/plugin_observer.cc - Issue 293393010: Move initial metrics gathering tasks out of MetricsService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_observer.cc

Issue 293393010: Move initial metrics gathering tasks out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_service_unittest.cc ('K') | « chrome/browser/metrics/plugin_metrics_provider.cc ('k') | chrome/browser/prefs/browser_prefs.cc » ('j') | components/metrics/metrics_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugins/plugin_observer.cc

diff --git a/chrome/browser/plugins/plugin_observer.cc b/chrome/browser/plugins/plugin_observer.cc

index 0848e1df9f4d67f2b277126a87bcc039d6426579..423e122a1763321acb6c9aa082877a7fb7ca7131 100644

--- a/chrome/browser/plugins/plugin_observer.cc

+++ b/chrome/browser/plugins/plugin_observer.cc

@@ -15,7 +15,7 @@

#include "chrome/browser/infobars/infobar_service.h"

#include "chrome/browser/infobars/simple_alert_infobar_delegate.h"

#include "chrome/browser/lifetime/application_lifetime.h"

-#include "chrome/browser/metrics/metrics_service.h"

+#include "chrome/browser/metrics/plugin_metrics_provider.h"

#include "chrome/browser/plugins/plugin_finder.h"

#include "chrome/browser/plugins/plugin_infobar_delegates.h"

#include "chrome/browser/profiles/profile.h"

@@ -456,7 +456,8 @@ void PluginObserver::OnOpenAboutPlugins() {

}

void PluginObserver::OnCouldNotLoadPlugin(const base::FilePath& plugin_path) {

- g_browser_process->metrics_service()->LogPluginLoadingError(plugin_path);

+ g_browser_process->plugin_metrics_provider()->LogPluginLoadingError(

blundell 2014/05/27 15:55:49 I assume that plugins are guaranteed to be enabled

+ plugin_path);

base::string16 plugin_name =

PluginService::GetInstance()->GetPluginDisplayNameByPath(plugin_path);

SimpleAlertInfoBarDelegate::Create(