chrome/browser/metrics/metrics_service_unittest.cc - Issue 293393010: Move initial metrics gathering tasks out of MetricsService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service_unittest.cc

Issue 293393010: Move initial metrics gathering tasks out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_service.h ('K') | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/browser/metrics/metrics_services_manager.h » ('j') | chrome/browser/plugins/plugin_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_service_unittest.cc

diff --git a/chrome/browser/metrics/metrics_service_unittest.cc b/chrome/browser/metrics/metrics_service_unittest.cc

index aebb05ad949d7302e066ca74806a8c07a2dd9eb8..8b89af2b98b3ca0597612306c42ef97dfd287919 100644

--- a/chrome/browser/metrics/metrics_service_unittest.cc

+++ b/chrome/browser/metrics/metrics_service_unittest.cc

@@ -278,6 +278,7 @@ TEST_F(MetricsServiceTest, RegisterSyntheticTrial) {

TEST_F(MetricsServiceTest, MetricsServiceObserver) {

metrics::TestMetricsServiceClient client;

MetricsService service(GetMetricsStateManager(), &client, GetLocalState());

+ service.InitializeMetricsRecordingState();

blundell 2014/05/27 15:55:49 Needed due to the client causing a MetricsService

TestMetricsServiceObserver observer1;

TestMetricsServiceObserver observer2;