components/metrics/metrics_provider.h - Issue 293393010: Move initial metrics gathering tasks out of MetricsService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_provider.h

Issue 293393010: Move initial metrics gathering tasks out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/metrics/metrics_provider.h

diff --git a/components/metrics/metrics_provider.h b/components/metrics/metrics_provider.h

index 001e66a42c6330f55a673840983bf24570454c97..fe02029247f6873e5cb17c522b7707a7add4c8f3 100644

--- a/components/metrics/metrics_provider.h

+++ b/components/metrics/metrics_provider.h

@@ -44,6 +44,9 @@ class MetricsProvider {

virtual void ProvideGeneralMetrics(

ChromeUserMetricsExtension* uma_proto) {}

+ // TODO(blundell): What should this comment be?

+ virtual void RecordCurrentState() {}

blundell 2014/05/27 15:55:49 Ideas on naming and commenting for this method?

private:

DISALLOW_COPY_AND_ASSIGN(MetricsProvider);

};

« chrome/browser/plugins/plugin_observer.cc ('K') | « chrome/test/base/testing_browser_process.cc ('k') | no next file » | no next file with comments »