Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2933873002: [ObjC ARC] Converts ios/chrome/browser/passwords:passwords to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, vabr+watchlistpasswordmanager_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, gcasto+watchlist_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/passwords:passwords to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2933873002 Cr-Commit-Position: refs/heads/master@{#479134} Committed: https://chromium.googlesource.com/chromium/src/+/82def10ead4edd5bd6d69405345f77b0d2c3222d

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Cleanup, removed spurious files. #

Total comments: 9

Patch Set 4 : fix names and nil assignments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -108 lines) Patch
M ios/chrome/browser/passwords/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.mm View 3 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm View 3 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/passwords/js_password_manager.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/passwords/password_controller.mm View 1 2 3 12 chunks +20 lines, -15 lines 0 comments Download
M ios/chrome/browser/passwords/password_generation_agent.h View 1 2 3 2 chunks +10 lines, -10 lines 0 comments Download
M ios/chrome/browser/passwords/password_generation_agent.mm View 1 2 3 11 chunks +50 lines, -53 lines 0 comments Download
M ios/chrome/browser/passwords/password_generation_edit_view.mm View 2 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/passwords/password_generation_offer_view.mm View 3 chunks +6 lines, -4 lines 0 comments Download
M ios/chrome/browser/passwords/update_password_infobar_controller.mm View 1 2 5 chunks +8 lines, -17 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
marq (ping after 24h)
Rebased
3 years, 6 months ago (2017-06-13 07:15:30 UTC) #5
marq (ping after 24h)
Cleanup, removed spurious files.
3 years, 6 months ago (2017-06-13 08:20:36 UTC) #10
marq (ping after 24h)
3 years, 6 months ago (2017-06-13 10:32:18 UTC) #14
vabr (Chromium)
Thanks for converting passwords code to ARC! I have some questions below. Other than that, ...
3 years, 6 months ago (2017-06-13 15:23:53 UTC) #17
marq (ping after 24h)
fix names and nil assignments.
3 years, 6 months ago (2017-06-13 17:36:27 UTC) #18
marq (ping after 24h)
I've renamed some things so they don't look like class names, and fixed some incorrect ...
3 years, 6 months ago (2017-06-13 17:39:04 UTC) #19
vabr (Chromium)
Thank you, LGTM! And I like the creative way to rename the arguments to satisfy ...
3 years, 6 months ago (2017-06-13 17:49:52 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933873002/60001
3 years, 6 months ago (2017-06-13 18:50:31 UTC) #22
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 20:36:20 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/82def10ead4edd5bd6d69405345f...

Powered by Google App Engine
This is Rietveld 408576698