[iOS] Break retain cycle in InfoBars.

[iOS] Break retain cycle in InfoBars.

This CLs breaks retain cycles such as:
InfoBarView -> LabelLinkController ->
BeforeTranslateInfoBarController -> InfoBarView

BUG=732384
Review-Url: https://codereview.chromium.org/2933833002
Cr-Commit-Position: refs/heads/master@{#478618}
Committed: https://chromium.googlesource.com/chromium/src/+/db9fc12b563cc860af67e91a571c262afcef72f8

[jif, 2017-06-12 13:49:53]

Description was changed from

==========
Break infobar retain cycle.

This CLs breaks retain cycles such as:
InfoBarView -> LabelLinkController -> BeforeTranslateInfoBarController ->
InfoBarView

BUG=None.
==========

to

==========
[iOS] Break InfoBar retain cycle.

This CLs breaks retain cycles such as:
InfoBarView -> LabelLinkController ->
BeforeTranslateInfoBarController -> InfoBarView

BUG=732384
==========

[jif, 2017-06-12 13:49:53]

jif@chromium.org changed reviewers:
+ sdefresne@chromium.org

[jif, 2017-06-12 13:51:05]

ptal

[jif, 2017-06-12 13:51:12]

Patchset #1 (id:1) has been deleted

[jif, 2017-06-12 13:51:27]

Description was changed from

==========
[iOS] Break InfoBar retain cycle.

This CLs breaks retain cycles such as:
InfoBarView -> LabelLinkController ->
BeforeTranslateInfoBarController -> InfoBarView

BUG=732384
==========

to

==========
[iOS] Break retain cycle in InfoBars.

This CLs breaks retain cycles such as:
InfoBarView -> LabelLinkController ->
BeforeTranslateInfoBarController -> InfoBarView

BUG=732384
==========

[sdefresne, 2017-06-12 14:14:24]

lgtm

https://codereview.chromium.org/2933833002/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/update_password_infobar_controller.mm (right):

https://codereview.chromium.org/2933833002/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/update_password_infobar_controller.mm:68:
base::scoped_nsobject<BeforeTranslateInfoBarController> strongSelf(
nit: I think it is okay to do the following

  [weakSelf infoBarLinkDidPress:tag];

https://codereview.chromium.org/2933833002/diff/20001/ios/chrome/browser/tran...
File ios/chrome/browser/translate/before_translate_infobar_controller.mm
(right):

https://codereview.chromium.org/2933833002/diff/20001/ios/chrome/browser/tran...
ios/chrome/browser/translate/before_translate_infobar_controller.mm:182:
[strongSelf infobarLinkDidPress:tag];
ditto

[jif, 2017-06-12 14:27:57]

Patchset #2 (id:40001) has been deleted

[jif, 2017-06-12 14:38:09]

The CQ bit was checked by jif@chromium.org

[jif, 2017-06-12 14:38:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2933833002/#ps60001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-06-12 14:38:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 14:50:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497278289518030,
"parent_rev": "804e16e2b137546476881afd0c3034582072ddcd", "commit_rev":
"db9fc12b563cc860af67e91a571c262afcef72f8"}

[commit-bot: I haz the power, 2017-06-12 14:51:00]

Description was changed from

==========
[iOS] Break retain cycle in InfoBars.

This CLs breaks retain cycles such as:
InfoBarView -> LabelLinkController ->
BeforeTranslateInfoBarController -> InfoBarView

BUG=732384
==========

to

==========
[iOS] Break retain cycle in InfoBars.

This CLs breaks retain cycles such as:
InfoBarView -> LabelLinkController ->
BeforeTranslateInfoBarController -> InfoBarView

BUG=732384

Review-Url: https://codereview.chromium.org/2933833002
Cr-Commit-Position: refs/heads/master@{#478618}
Committed:
https://chromium.googlesource.com/chromium/src/+/db9fc12b563cc860af67e91a571c...
==========

[commit-bot: I haz the power, 2017-06-12 14:51:02]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/db9fc12b563cc860af67e91a571c...