Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Side by Side Diff: ios/chrome/browser/translate/before_translate_infobar_controller.mm

Issue 2933833002: [iOS] Break retain cycle in InfoBars. (Closed)
Patch Set: Addressed comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/passwords/update_password_infobar_controller.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/translate/before_translate_infobar_controller.h" 5 #include "ios/chrome/browser/translate/before_translate_infobar_controller.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #import <UIKit/UIKit.h> 8 #import <UIKit/UIKit.h>
9 9
10 #include "base/ios/weak_nsobject.h"
10 #include "base/logging.h" 11 #include "base/logging.h"
11 #include "base/mac/scoped_nsobject.h" 12 #include "base/mac/scoped_nsobject.h"
12 #include "base/strings/sys_string_conversions.h" 13 #include "base/strings/sys_string_conversions.h"
13 #include "base/strings/utf_string_conversions.h" 14 #include "base/strings/utf_string_conversions.h"
14 #include "components/strings/grit/components_strings.h" 15 #include "components/strings/grit/components_strings.h"
15 #include "components/translate/core/browser/translate_infobar_delegate.h" 16 #include "components/translate/core/browser/translate_infobar_delegate.h"
16 #include "ios/chrome/browser/translate/translate_infobar_tags.h" 17 #include "ios/chrome/browser/translate/translate_infobar_tags.h"
17 #import "ios/chrome/browser/ui/infobars/infobar_view.h" 18 #import "ios/chrome/browser/ui/infobars/infobar_view.h"
18 #import "ios/chrome/browser/ui/infobars/infobar_view_delegate.h" 19 #import "ios/chrome/browser/ui/infobars/infobar_view_delegate.h"
19 #include "ui/base/l10n/l10n_util.h" 20 #include "ui/base/l10n/l10n_util.h"
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 base::string16 originalLanguageWithLink = 166 base::string16 originalLanguageWithLink =
166 base::SysNSStringToUTF16([[view class] 167 base::SysNSStringToUTF16([[view class]
167 stringAsLink:originalLanguage 168 stringAsLink:originalLanguage
168 tag:TranslateInfoBarIOSTag::BEFORE_SOURCE_LANGUAGE]); 169 tag:TranslateInfoBarIOSTag::BEFORE_SOURCE_LANGUAGE]);
169 base::string16 targetLanguageWithLink = base::SysNSStringToUTF16([[view class] 170 base::string16 targetLanguageWithLink = base::SysNSStringToUTF16([[view class]
170 stringAsLink:targetLanguage 171 stringAsLink:targetLanguage
171 tag:TranslateInfoBarIOSTag::BEFORE_TARGET_LANGUAGE]); 172 tag:TranslateInfoBarIOSTag::BEFORE_TARGET_LANGUAGE]);
172 NSString* label = 173 NSString* label =
173 l10n_util::GetNSStringF(IDS_TRANSLATE_INFOBAR_BEFORE_MESSAGE_IOS, 174 l10n_util::GetNSStringF(IDS_TRANSLATE_INFOBAR_BEFORE_MESSAGE_IOS,
174 originalLanguageWithLink, targetLanguageWithLink); 175 originalLanguageWithLink, targetLanguageWithLink);
176
177 base::WeakNSObject<BeforeTranslateInfoBarController> weakSelf(self);
175 [view addLabel:label 178 [view addLabel:label
176 action:^(NSUInteger tag) { 179 action:^(NSUInteger tag) {
177 [self infobarLinkDidPress:tag]; 180 [weakSelf infobarLinkDidPress:tag];
178 }]; 181 }];
179 } 182 }
180 183
181 - (void)languageSelectionDone { 184 - (void)languageSelectionDone {
182 size_t selectedRow = [_languagePicker selectedRowInComponent:0]; 185 size_t selectedRow = [_languagePicker selectedRowInComponent:0];
183 std::string lang = _translateInfoBarDelegate->language_code_at(selectedRow); 186 std::string lang = _translateInfoBarDelegate->language_code_at(selectedRow);
184 if (_languageSelectionType == 187 if (_languageSelectionType ==
185 TranslateInfoBarIOSTag::BEFORE_SOURCE_LANGUAGE && 188 TranslateInfoBarIOSTag::BEFORE_SOURCE_LANGUAGE &&
186 lang != _translateInfoBarDelegate->target_language_code()) { 189 lang != _translateInfoBarDelegate->target_language_code()) {
187 _translateInfoBarDelegate->UpdateOriginalLanguage(lang); 190 _translateInfoBarDelegate->UpdateOriginalLanguage(lang);
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 [super removeView]; 369 [super removeView];
367 [self dismissLanguageSelectionView]; 370 [self dismissLanguageSelectionView];
368 } 371 }
369 372
370 - (void)detachView { 373 - (void)detachView {
371 [super detachView]; 374 [super detachView];
372 [self dismissLanguageSelectionView]; 375 [self dismissLanguageSelectionView];
373 } 376 }
374 377
375 @end 378 @end
OLDNEW
« no previous file with comments | « ios/chrome/browser/passwords/update_password_infobar_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698