Move chrome/browser/manifest to content/browser.

Move chrome/browser/manifest to content/browser.

This change is related to PaymentHandler API[1]. We added support for payment
instrument icons feature[2]. It is very similar to the icons field in
WebAppManifest. So, moving the manifest icon downloader and selector from
chrome to content, we can remove duplicated codes. Fortunately, the related
files use only content/public APIs and have no dependency with chrome layer.
So, they can be moved easily.

[1] https://w3c.github.io/payment-handler/
[2] https://codereview.chromium.org/2925063003/

BUG=720029
Review-Url: https://codereview.chromium.org/2933743002
Cr-Commit-Position: refs/heads/master@{#479424}
Committed: https://chromium.googlesource.com/chromium/src/+/84cadc8bbdf0d82af266f43c00d43424d0e48fa7

[zino, 2017-06-11 17:36:36]

Description was changed from

==========
Move chrome/browser/manifest to content/browser.

BUG=
==========

to

==========
Move chrome/browser/manifest to content/browser.

BUG=
==========

[zino, 2017-06-12 16:48:10]

Description was changed from

==========
Move chrome/browser/manifest to content/browser.

BUG=
==========

to

==========
Move chrome/browser/manifest to content/browser.

This change is related to PaymentHandler API. We added support for payment
instrument icons feature[1]. It is very similar to the icons field in
WebAppManifest. So, moving the manifest icon downloader and selector from
chrome to content, we can remove duplicated codes. Fortuneately, the related
files use only content/public APIs and have no depedency with chrome layer.
So, they can be moved easily.

[1] https://codereview.chromium.org/2925063003/

BUG=720029
==========

[zino, 2017-06-12 16:48:48]

Description was changed from

==========
Move chrome/browser/manifest to content/browser.

This change is related to PaymentHandler API. We added support for payment
instrument icons feature[1]. It is very similar to the icons field in
WebAppManifest. So, moving the manifest icon downloader and selector from
chrome to content, we can remove duplicated codes. Fortuneately, the related
files use only content/public APIs and have no depedency with chrome layer.
So, they can be moved easily.

[1] https://codereview.chromium.org/2925063003/

BUG=720029
==========

to

==========
Move chrome/browser/manifest to content/browser.

This change is related to PaymentHandler API. We added support for payment
instrument icons feature[1]. It is very similar to the icons field in
WebAppManifest. So, moving the manifest icon downloader and selector from
chrome to content, we can remove duplicated codes. Fortunately, the related
files use only content/public APIs and have no dependency with chrome layer.
So, they can be moved easily.

[1] https://codereview.chromium.org/2925063003/

BUG=720029
==========

[zino, 2017-06-12 16:49:48]

Description was changed from

==========
Move chrome/browser/manifest to content/browser.

This change is related to PaymentHandler API. We added support for payment
instrument icons feature[1]. It is very similar to the icons field in
WebAppManifest. So, moving the manifest icon downloader and selector from
chrome to content, we can remove duplicated codes. Fortunately, the related
files use only content/public APIs and have no dependency with chrome layer.
So, they can be moved easily.

[1] https://codereview.chromium.org/2925063003/

BUG=720029
==========

to

==========
Move chrome/browser/manifest to content/browser.

This change is related to PaymentHandler API[1]. We added support for payment
instrument icons feature[2]. It is very similar to the icons field in
WebAppManifest. So, moving the manifest icon downloader and selector from
chrome to content, we can remove duplicated codes. Fortunately, the related
files use only content/public APIs and have no dependency with chrome layer.
So, they can be moved easily.

[1] https://w3c.github.io/payment-handler/
[2] https://codereview.chromium.org/2925063003/

BUG=720029
==========

[zino, 2017-06-12 17:01:03]

jinho.bang@samsung.com changed reviewers:
+ gogerald@chromium.org, rouslan@chromium.org

[zino, 2017-06-12 17:05:28]

Hi gogerald@ and rouslan@,

This change is trying to move the manifest icon selector/downloader from chrome
layer to content layer.
After landing 2925063003 patch, we can use this for downloading/selecting best
matched icon in follow-up CL.
Is this reasonable? WDYT?

[please use gerrit instead, 2017-06-12 23:57:23]

Good idea!

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
File content/browser/manifest/manifest_icon_downloader.cc (right):

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader.cc:10: #include
"content/public/browser/manifest_icon_downloader.h"
This line should be on top.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader.cc:18: namespace content {
Newline below.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader.cc:185: }
newline below

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader.cc:186: }
  // namespace content

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
File content/browser/manifest/manifest_icon_downloader_unittest.cc (right):

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader_unittest.cc:145: }
newline above

// namespace content

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
File content/browser/manifest/manifest_icon_selector.cc (right):

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_selector.cc:10: #include
"content/public/browser/manifest_icon_selector.h"
Should be on top.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_selector.cc:12: namespace content {
Newline below.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_selector.cc:83: }
Newline above.

// namespace content

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
File content/browser/manifest/manifest_icon_selector_unittest.cc (right):

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_selector_unittest.cc:13: 
namespace content { --- should be here.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_selector_unittest.cc:498: }
newline above.

// namespace content

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
File content/public/browser/manifest_icon_downloader.h (right):

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
content/public/browser/manifest_icon_downloader.h:5: #ifndef
CHROME_BROWSER_MANIFEST_MANIFEST_ICON_DOWNLOADER_H_
Update the header guards.

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
content/public/browser/manifest_icon_downloader.h:26: namespace content {
newline below

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
File content/public/browser/manifest_icon_selector.h (right):

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
content/public/browser/manifest_icon_selector.h:5: #ifndef
CHROME_BROWSER_MANIFEST_MANIFEST_ICON_SELECTOR_H_
Update the header guards.

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
content/public/browser/manifest_icon_selector.h:12: namespace content {
Newline below.

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
content/public/browser/manifest_icon_selector.h:36: }
Newline above.

// namespace content

[zino, 2017-06-13 16:07:45]

Thank you for review. PTAL

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
File content/browser/manifest/manifest_icon_downloader.cc (right):

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader.cc:10: #include
"content/public/browser/manifest_icon_downloader.h"
On 2017/06/12 23:57:22, rouslan wrote:
> This line should be on top.

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader.cc:18: namespace content {
On 2017/06/12 23:57:22, rouslan wrote:
> Newline below.

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader.cc:185: }
On 2017/06/12 23:57:22, rouslan wrote:
> newline below

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader.cc:186: }
On 2017/06/12 23:57:22, rouslan wrote:
>   // namespace content

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
File content/browser/manifest/manifest_icon_downloader_unittest.cc (right):

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader_unittest.cc:145: }
On 2017/06/12 23:57:22, rouslan wrote:
> newline above
> 
> // namespace content

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
File content/browser/manifest/manifest_icon_selector.cc (right):

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_selector.cc:10: #include
"content/public/browser/manifest_icon_selector.h"
On 2017/06/12 23:57:22, rouslan wrote:
> Should be on top.

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_selector.cc:12: namespace content {
On 2017/06/12 23:57:22, rouslan wrote:
> Newline below.

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_selector.cc:83: }
On 2017/06/12 23:57:22, rouslan wrote:
> Newline above.
> 
> // namespace content

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
File content/browser/manifest/manifest_icon_selector_unittest.cc (right):

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_selector_unittest.cc:13: 
On 2017/06/12 23:57:22, rouslan wrote:
> namespace content { --- should be here.

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/browser/manifes...
content/browser/manifest/manifest_icon_selector_unittest.cc:498: }
On 2017/06/12 23:57:22, rouslan wrote:
> newline above.
> 
> // namespace content

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
File content/public/browser/manifest_icon_downloader.h (right):

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
content/public/browser/manifest_icon_downloader.h:5: #ifndef
CHROME_BROWSER_MANIFEST_MANIFEST_ICON_DOWNLOADER_H_
On 2017/06/12 23:57:22, rouslan wrote:
> Update the header guards.

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
content/public/browser/manifest_icon_downloader.h:26: namespace content {
On 2017/06/12 23:57:22, rouslan wrote:
> newline below

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
File content/public/browser/manifest_icon_selector.h (right):

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
content/public/browser/manifest_icon_selector.h:5: #ifndef
CHROME_BROWSER_MANIFEST_MANIFEST_ICON_SELECTOR_H_
On 2017/06/12 23:57:22, rouslan wrote:
> Update the header guards.

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
content/public/browser/manifest_icon_selector.h:12: namespace content {
On 2017/06/12 23:57:22, rouslan wrote:
> Newline below.

Done.

https://codereview.chromium.org/2933743002/diff/20001/content/public/browser/...
content/public/browser/manifest_icon_selector.h:36: }
On 2017/06/12 23:57:22, rouslan wrote:
> Newline above.
> 
> // namespace content

Done.

[zino, 2017-06-13 16:09:16]

jinho.bang@samsung.com changed reviewers:
+ dfalcantara@chromium.org, jochen@chromium.org

[zino, 2017-06-13 16:09:17]

jochen@, dfalcantara@ PTAL (as an owners)

[gone, 2017-06-13 17:00:54]

lgtm

[gone, 2017-06-13 17:01:37]

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
File content/browser/manifest/OWNERS (right):

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
content/browser/manifest/OWNERS:2: dfalcantara@chromium.org
Make this so I'm only the OWNER of the files you're moving.

[zino, 2017-06-13 18:08:46]

Thank you for l-g-t-m.

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
File content/browser/manifest/OWNERS (right):

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
content/browser/manifest/OWNERS:2: dfalcantara@chromium.org
On 2017/06/13 17:01:37, dfalcantara wrote:
> Make this so I'm only the OWNER of the files you're moving.

mlamouri@ is already the owner?

[gone, 2017-06-13 18:14:01]

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
File content/browser/manifest/OWNERS (right):

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
content/browser/manifest/OWNERS:2: dfalcantara@chromium.org
On 2017/06/13 18:08:46, zino wrote:
> On 2017/06/13 17:01:37, dfalcantara wrote:
> > Make this so I'm only the OWNER of the files you're moving.
> 
> mlamouri@ is already the owner?

Yeah, but I don't know anything about the other files you're making me an OWNER
of in this directory.

[please use gerrit instead, 2017-06-13 20:41:36]

lgtm % Dan's request.

[jochen (gone - plz use gerrit), 2017-06-14 08:19:54]

lgtm with namespace cleaned up

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
File content/browser/manifest/manifest_icon_downloader.cc (right):

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader.cc:37: content::WebContents*
web_contents)
nit. no content:: inside namespace content (here and everywhere)

[jochen (gone - plz use gerrit), 2017-06-14 08:21:26]

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
File content/browser/manifest/OWNERS (right):

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
content/browser/manifest/OWNERS:2: dfalcantara@chromium.org
On 2017/06/13 at 18:14:01, dfalcantara wrote:
> On 2017/06/13 18:08:46, zino wrote:
> > On 2017/06/13 17:01:37, dfalcantara wrote:
> > > Make this so I'm only the OWNER of the files you're moving.
> > 
> > mlamouri@ is already the owner?
> 
> Yeah, but I don't know anything about the other files you're making me an
OWNER of in this directory.

I think the request is to add

per-file manifest_icon_*=dfalcantara@chromium.org

so mlamouri@ wouldn't be affected

[gogerald1, 2017-06-14 13:30:09]

lgtm

[zino, 2017-06-14 14:18:18]

Thank you for review.

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
File content/browser/manifest/manifest_icon_downloader.cc (right):

https://codereview.chromium.org/2933743002/diff/60001/content/browser/manifes...
content/browser/manifest/manifest_icon_downloader.cc:37: content::WebContents*
web_contents)
On 2017/06/14 08:19:54, jochen wrote:
> nit. no content:: inside namespace content (here and everywhere)

Done.

[zino, 2017-06-14 14:18:26]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-06-14 14:18:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, jochen@chromium.org, gogerald@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2933743002/#ps80001
(title: "Move chrome/browser/manifest to content/browser.")

[commit-bot: I haz the power, 2017-06-14 14:18:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 14:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 14:52:53]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[zino, 2017-06-14 15:12:42]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-06-14 15:12:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, jochen@chromium.org, gogerald@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2933743002/#ps100001
(title: "rebased")

[commit-bot: I haz the power, 2017-06-14 15:13:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 16:59:37]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1497453162693070,
"parent_rev": "e0b1b5815b5e272c67bf0f63a96bb65f85814e1b", "commit_rev":
"84cadc8bbdf0d82af266f43c00d43424d0e48fa7"}

[commit-bot: I haz the power, 2017-06-14 16:59:48]

Description was changed from

==========
Move chrome/browser/manifest to content/browser.

This change is related to PaymentHandler API[1]. We added support for payment
instrument icons feature[2]. It is very similar to the icons field in
WebAppManifest. So, moving the manifest icon downloader and selector from
chrome to content, we can remove duplicated codes. Fortunately, the related
files use only content/public APIs and have no dependency with chrome layer.
So, they can be moved easily.

[1] https://w3c.github.io/payment-handler/
[2] https://codereview.chromium.org/2925063003/

BUG=720029
==========

to

==========
Move chrome/browser/manifest to content/browser.

This change is related to PaymentHandler API[1]. We added support for payment
instrument icons feature[2]. It is very similar to the icons field in
WebAppManifest. So, moving the manifest icon downloader and selector from
chrome to content, we can remove duplicated codes. Fortunately, the related
files use only content/public APIs and have no dependency with chrome layer.
So, they can be moved easily.

[1] https://w3c.github.io/payment-handler/
[2] https://codereview.chromium.org/2925063003/

BUG=720029

Review-Url: https://codereview.chromium.org/2933743002
Cr-Commit-Position: refs/heads/master@{#479424}
Committed:
https://chromium.googlesource.com/chromium/src/+/84cadc8bbdf0d82af266f43c00d4...
==========

[commit-bot: I haz the power, 2017-06-14 16:59:51]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/84cadc8bbdf0d82af266f43c00d4...