content/browser/manifest/OWNERS - Issue 2933743002: Move chrome/browser/manifest to content/browser.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/manifest/OWNERS

Issue 2933743002: Move chrome/browser/manifest to content/browser. (Closed)

Patch Set: Move chrome/browser/manifest to content/browser. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 mlamouri@chromium.org	1 mlamouri@chromium.org

	2 dfalcantara@chromium.org
	gone 2017/06/13 17:01:37 Make this so I'm only the OWNER of the files you'r Make this so I'm only the OWNER of the files you're moving. zino 2017/06/13 18:08:46 mlamouri@ is already the owner? Show quoted text On 2017/06/13 17:01:37, dfalcantara wrote: > Make this so I'm only the OWNER of the files you're moving. mlamouri@ is already the owner? gone 2017/06/13 18:14:01 Yeah, but I don't know anything about the other fi Show quoted text On 2017/06/13 18:08:46, zino wrote: > On 2017/06/13 17:01:37, dfalcantara wrote: > > Make this so I'm only the OWNER of the files you're moving. > > mlamouri@ is already the owner? Yeah, but I don't know anything about the other files you're making me an OWNER of in this directory. jochen (gone - plz use gerrit) 2017/06/14 08:21:26 I think the request is to add per-file manifest_i Show quoted text On 2017/06/13 at 18:14:01, dfalcantara wrote: > On 2017/06/13 18:08:46, zino wrote: > > On 2017/06/13 17:01:37, dfalcantara wrote: > > > Make this so I'm only the OWNER of the files you're moving. > > > > mlamouri@ is already the owner? > > Yeah, but I don't know anything about the other files you're making me an OWNER of in this directory. I think the request is to add per-file manifest_icon_*=dfalcantara@chromium.org so mlamouri@ wouldn't be affected
2	3

3 # COMPONENT: Manifest	4 # COMPONENT: Manifest

OLD	NEW