Promote 'model' from state to dimension for Macs.

Promote 'model' from state to dimension for Macs.

- The new dimension 'model' permits selecting bots based on hardware.
- Fix a problem with xcode version detection where the bot would be quarantined
  when XCode is not installed due to an empty dimension value. We never hit it
  yet just because XCode is installed everywhere.

R=kbr@chromium.org
BUG=731496
Review-Url: https://codereview.chromium.org/2933593002
Committed: https://github.com/luci/luci-py/commit/9727759af4def9f652d6a08cff42d17584d19e4b

[Ken Russell (switch to Gerrit), 2017-06-09 20:34:00]

Cool. LGTM

https://codereview.chromium.org/2933593002/diff/20001/appengine/swarming/swar...
File appengine/swarming/swarming_bot/api/os_utilities.py (right):

https://codereview.chromium.org/2933593002/diff/20001/appengine/swarming/swar...
appengine/swarming/swarming_bot/api/os_utilities.py:943: dimensions[u'model'] =
[model]
Might want to make this a more specific name like machine_model, hardware_model,
etc.

[M-A Ruel, 2017-06-09 20:44:05]

https://codereview.chromium.org/2933593002/diff/20001/appengine/swarming/swar...
File appengine/swarming/swarming_bot/api/os_utilities.py (right):

https://codereview.chromium.org/2933593002/diff/20001/appengine/swarming/swar...
appengine/swarming/swarming_bot/api/os_utilities.py:943: dimensions[u'model'] =
[model]
On 2017/06/09 20:34:00, Ken Russell wrote:
> Might want to make this a more specific name like machine_model,
hardware_model,
> etc.

Changed to mac_model. wdyt?

[Ken Russell (switch to Gerrit), 2017-06-09 20:45:33]

https://codereview.chromium.org/2933593002/diff/20001/appengine/swarming/swar...
File appengine/swarming/swarming_bot/api/os_utilities.py (right):

https://codereview.chromium.org/2933593002/diff/20001/appengine/swarming/swar...
appengine/swarming/swarming_bot/api/os_utilities.py:943: dimensions[u'model'] =
[model]
On 2017/06/09 20:44:05, M-A Ruel wrote:
> On 2017/06/09 20:34:00, Ken Russell wrote:
> > Might want to make this a more specific name like machine_model,
> hardware_model,
> > etc.
> 
> Changed to mac_model. wdyt?

SGTM.

[M-A Ruel, 2017-06-09 20:45:44]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2017-06-09 20:45:44]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2933593002/#ps40001
(title: "model -> mac_model")

[commit-bot: I haz the power, 2017-06-09 20:45:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 20:49:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497041144379270,
"parent_rev": "6ad3c41630bbc5371ed955c750a2116c5d0b0a2a", "commit_rev":
"9727759af4def9f652d6a08cff42d17584d19e4b"}

[commit-bot: I haz the power, 2017-06-09 20:49:59]

Description was changed from

==========
Promote 'model' from state to dimension for Macs.

- The new dimension 'model' permits selecting bots based on hardware.
- Fix a problem with xcode version detection where the bot would be quarantined
  when XCode is not installed due to an empty dimension value. We never hit it
  yet just because XCode is installed everywhere.

R=kbr@chromium.org
BUG=731496
==========

to

==========
Promote 'model' from state to dimension for Macs.

- The new dimension 'model' permits selecting bots based on hardware.
- Fix a problem with xcode version detection where the bot would be quarantined
  when XCode is not installed due to an empty dimension value. We never hit it
  yet just because XCode is installed everywhere.

R=kbr@chromium.org
BUG=731496

Review-Url: https://codereview.chromium.org/2933593002
Committed:
https://github.com/luci/luci-py/commit/9727759af4def9f652d6a08cff42d17584d19e4b
==========

[commit-bot: I haz the power, 2017-06-09 20:50:00]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/9727759af4def9f652d6a08cff42d17584d19e4b