Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: appengine/swarming/swarming_bot/api/os_utilities_test.py

Issue 2933593002: Promote 'model' from state to dimension for Macs. (Closed)
Patch Set: model -> mac_model Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/swarming_bot/api/os_utilities.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/swarming_bot/api/os_utilities_test.py
diff --git a/appengine/swarming/swarming_bot/api/os_utilities_test.py b/appengine/swarming/swarming_bot/api/os_utilities_test.py
index a997cc6f76a0c6a06c4b9f11821ab5989faf0676..96a8675820b63856e632c37c072d27ec79b31145 100755
--- a/appengine/swarming/swarming_bot/api/os_utilities_test.py
+++ b/appengine/swarming/swarming_bot/api/os_utilities_test.py
@@ -98,6 +98,7 @@ class TestOsUtilities(auto_stub.TestCase):
actual.discard(u'hidpi')
expected = {u'cores', u'cpu', u'gpu', u'id', u'os', u'pool'}
if sys.platform == 'darwin':
+ expected.add(u'mac_model')
expected.add(u'xcode_version')
self.assertEqual(expected, actual)
@@ -112,7 +113,6 @@ class TestOsUtilities(auto_stub.TestCase):
if sys.platform in ('cygwin', 'win32'):
expected.add(u'cygwin')
if sys.platform == 'darwin':
- expected.add(u'model')
expected.add(u'xcode')
if sys.platform == 'win32':
expected.add(u'integrity')
« no previous file with comments | « appengine/swarming/swarming_bot/api/os_utilities.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698