Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2933513002: Avoid to reuse local variable in ComputeInlineBoxPosition() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid to reuse local variable in ComputeInlineBoxPosition() This patch chagnes |ComputeInlineBoxPosition()| to avoid to reuse local variable |equivalent| by introducing two const-variable and another call site of |ComputeInlineBoxPosition()| to explicitly denotes what value is used, e.g. |downstream_equivalent| or |upstream_equivalent|, for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2933513002 Cr-Commit-Position: refs/heads/master@{#478543} Committed: https://chromium.googlesource.com/chromium/src/+/f8f46de2517307a1a0c72f1c41b72594e21028d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-09 08:11:39 UTC) #5
Xiaocheng
lgtm
3 years, 6 months ago (2017-06-09 18:07:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933513002/1
3 years, 6 months ago (2017-06-12 01:40:22 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 03:15:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f8f46de2517307a1a0c72f1c41b7...

Powered by Google App Engine
This is Rietveld 408576698