Avoid to reuse local variable in ComputeInlineBoxPosition()

third_party/WebKit/Source/core/editing/VisibleUnits.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 755 matching lines @@
   if (!layout_object->IsText()) {
     inline_box = 0;
     if (CanHaveChildrenForEditing(anchor_node) &&
         layout_object->IsLayoutBlockFlow() &&
         HasRenderedNonAnonymousDescendantsWithHeight(layout_object)) {
       // Try a visually equivalent position with possibly opposite
       // editability. This helps in case |this| is in an editable block
       // but surrounded by non-editable positions. It acts to negate the
       // logic at the beginning of
       // |LayoutObject::createPositionWithAffinity()|.
-      PositionTemplate<Strategy> equivalent =
+      const PositionTemplate<Strategy>& downstream_equivalent =
           DownstreamIgnoringEditingBoundaries(position);
-      if (equivalent == position) {
-        equivalent = UpstreamIgnoringEditingBoundaries(position);
-        if (equivalent == position ||
-            DownstreamIgnoringEditingBoundaries(equivalent) == position)
-          return InlineBoxPosition(inline_box, caret_offset);
+      if (downstream_equivalent != position) {
+        return ComputeInlineBoxPosition(
+            downstream_equivalent, TextAffinity::kUpstream, primary_direction);
       }
+      const PositionTemplate<Strategy>& upstream_equivalent =
+          UpstreamIgnoringEditingBoundaries(position);
+      if (upstream_equivalent == position ||
+          DownstreamIgnoringEditingBoundaries(upstream_equivalent) == position)
+        return InlineBoxPosition(inline_box, caret_offset);
 
-      return ComputeInlineBoxPosition(equivalent, TextAffinity::kUpstream,
-                                      primary_direction);
+      return ComputeInlineBoxPosition(
+          upstream_equivalent, TextAffinity::kUpstream, primary_direction);
     }
     if (layout_object->IsBox()) {
       inline_box = ToLayoutBox(layout_object)->InlineBoxWrapper();
       if (!inline_box || (caret_offset > inline_box->CaretMinOffset() &&
                           caret_offset < inline_box->CaretMaxOffset()))
         return InlineBoxPosition(inline_box, caret_offset);
     }
   } else {
     LayoutText* text_layout_object = ToLayoutText(layout_object);
 
@@ skipping 1686 matching lines @@
 
 IntRect ComputeTextRect(const EphemeralRangeInFlatTree& range) {
   return EnclosingIntRect(ComputeTextRectTemplate(range));
 }
 
 FloatRect ComputeTextFloatRect(const EphemeralRange& range) {
   return ComputeTextRectTemplate(range);
 }
 
 }  // namespace blink