Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2933483005: gzip chrome://tracing resources. (Closed)

Created:
3 years, 6 months ago by sullivan
Modified:
3 years, 6 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, jam, darin-cc_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gzip chrome://tracing resources. Compiling locally, resources.pak goes from 16744913 bytes to 14952341 (nearly 1.8MiB savings). Review-Url: https://codereview.chromium.org/2933483005 Cr-Commit-Position: refs/heads/master@{#478678} Committed: https://chromium.googlesource.com/chromium/src/+/775f2fb6ca172043fa05479a909e5f78e1c881a1

Patch Set 1 #

Total comments: 2

Patch Set 2 : add begin_recording to gzip excluded paths and alphabetize. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/browser/tracing/generate_trace_viewer_grd.py View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sullivan
https://codereview.chromium.org/2933483005/diff/1/content/browser/tracing/tracing_ui.cc File content/browser/tracing/tracing_ui.cc (right): https://codereview.chromium.org/2933483005/diff/1/content/browser/tracing/tracing_ui.cc#newcode178 content/browser/tracing/tracing_ui.cc:178: const char kBeginRecordingPath[] = "json/begin_recording?"; What is this and ...
3 years, 6 months ago (2017-06-09 19:08:42 UTC) #1
sullivan
https://codereview.chromium.org/2933483005/diff/1/content/browser/tracing/tracing_ui.cc File content/browser/tracing/tracing_ui.cc (right): https://codereview.chromium.org/2933483005/diff/1/content/browser/tracing/tracing_ui.cc#newcode178 content/browser/tracing/tracing_ui.cc:178: const char kBeginRecordingPath[] = "json/begin_recording?"; On 2017/06/09 19:08:42, sullivan ...
3 years, 6 months ago (2017-06-09 21:22:30 UTC) #3
sullivan
Just to summarize what's happening here: I made this change, built in release mode, and ...
3 years, 6 months ago (2017-06-12 15:09:15 UTC) #4
sullivan
On 2017/06/12 15:09:15, sullivan wrote: > Just to summarize what's happening here: > > I ...
3 years, 6 months ago (2017-06-12 15:34:51 UTC) #5
Primiano Tucci (use gerrit)
LGTM. Looks like the other JS endpoints you cannot find refer to code that has ...
3 years, 6 months ago (2017-06-12 15:50:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933483005/20001
3 years, 6 months ago (2017-06-12 16:27:22 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 18:01:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/775f2fb6ca172043fa05479a909e...

Powered by Google App Engine
This is Rietveld 408576698