gzip chrome://tracing resources.

gzip chrome://tracing resources.

Compiling locally, resources.pak goes from 16744913 bytes to 14952341
(nearly 1.8MiB savings).

Review-Url: https://codereview.chromium.org/2933483005
Cr-Commit-Position: refs/heads/master@{#478678}
Committed: https://chromium.googlesource.com/chromium/src/+/775f2fb6ca172043fa05479a909e5f78e1c881a1

[sullivan, 2017-06-09 19:08:42]

https://codereview.chromium.org/2933483005/diff/1/content/browser/tracing/tra...
File content/browser/tracing/tracing_ui.cc (right):

https://codereview.chromium.org/2933483005/diff/1/content/browser/tracing/tra...
content/browser/tracing/tracing_ui.cc:178: const char kBeginRecordingPath[] =
"json/begin_recording?";
What is this and how is it used? I see it called from here:
https://github.com/catapult-project/catapult/blob/master/tracing/tracing/ui/e...

But that file has some other paths that aren't handled here:
/json/begin_monitoring
/json/end_monitoring
/json/capture_monitoring_compressed
/json/get_monitoring_status

What's going on there?

[sullivan, 2017-06-09 21:22:29]

sullivan@chromium.org changed reviewers:
+ nduca@chromium.org

[sullivan, 2017-06-09 21:22:30]

https://codereview.chromium.org/2933483005/diff/1/content/browser/tracing/tra...
File content/browser/tracing/tracing_ui.cc (right):

https://codereview.chromium.org/2933483005/diff/1/content/browser/tracing/tra...
content/browser/tracing/tracing_ui.cc:178: const char kBeginRecordingPath[] =
"json/begin_recording?";
On 2017/06/09 19:08:42, sullivan wrote:
> What is this and how is it used? I see it called from here:
>
https://github.com/catapult-project/catapult/blob/master/tracing/tracing/ui/e...
> 
> But that file has some other paths that aren't handled here:
> /json/begin_monitoring
> /json/end_monitoring
> /json/capture_monitoring_compressed
> /json/get_monitoring_status
> 
> What's going on there?

I ended up adding "json/begin_recording" to the gzip_excluded paths. I think
this should work, but I can't get that file to show up in the netstack when I
record traces.

[sullivan, 2017-06-12 15:09:15]

Just to summarize what's happening here:

I made this change, built in release mode, and noted the improvements to the
size of resources.pak. I tested recording a trace locally, with no problems. But
I can't get the "/json/begin_recording" URI referenced in the code to show up in
devtools net panel when I record the trace, so I am not 100% certain that uri is
working correctly and the querystring isn't required to be listed in exclusions.
Anyone have ideas?

[sullivan, 2017-06-12 15:34:51]

On 2017/06/12 15:09:15, sullivan wrote:
> Just to summarize what's happening here:
> 
> I made this change, built in release mode, and noted the improvements to the
> size of resources.pak. I tested recording a trace locally, with no problems.
But
> I can't get the "/json/begin_recording" URI referenced in the code to show up
in
> devtools net panel when I record the trace, so I am not 100% certain that uri
is
> working correctly and the querystring isn't required to be listed in
exclusions.
> Anyone have ideas?

Okay, I'm not sure what was happening on Friday, but I just checked again and
/json/begin_recording is showing up in devtools and working just fine.

The monitoring endpoints were removed in
https://codereview.chromium.org/1678503002, so this CL doesn't need to modify
them.

So as far as I know, this CL is working as intended and fully tested manually.
It's ready for review.

[Primiano Tucci (use gerrit), 2017-06-12 15:50:30]

primiano@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2017-06-12 15:50:30]

LGTM. Looks like the other JS endpoints  you cannot find refer to code that has
been nuked in https://codereview.chromium.org/1678503002 by Oystein. As regards
the devtools flakiness, I just got it locally (without your patch) on canary, so
it seems unrelated.
I'd say let's ship this and if nobody complains let's keep it a day (maybe send
a heads up to tracing@)

[sullivan, 2017-06-12 16:26:59]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2017-06-12 16:27:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 18:01:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497284819546800,
"parent_rev": "21f504945ba3712f0455a1b3711dcf576cda5ee3", "commit_rev":
"775f2fb6ca172043fa05479a909e5f78e1c881a1"}

[commit-bot: I haz the power, 2017-06-12 18:01:54]

Description was changed from

==========
gzip chrome://tracing resources.

Compiling locally, resources.pak goes from 16744913 bytes to 14952341
(nearly 1.8MiB savings).
==========

to

==========
gzip chrome://tracing resources.

Compiling locally, resources.pak goes from 16744913 bytes to 14952341
(nearly 1.8MiB savings).

Review-Url: https://codereview.chromium.org/2933483005
Cr-Commit-Position: refs/heads/master@{#478678}
Committed:
https://chromium.googlesource.com/chromium/src/+/775f2fb6ca172043fa05479a909e...
==========

[commit-bot: I haz the power, 2017-06-12 18:01:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/775f2fb6ca172043fa05479a909e...