Tracing: Removed monitoring mode

Tracing: Removed monitoring mode

This is not used by anyone it seems, and prevents ConvertableToTraceFormat from being used in a thread-safe manner.

NOTE: Dependent on https://codereview.chromium.org/1673893002 landing in Catapult first.

BUG=559117
Committed: https://crrev.com/166c6e0b0157f7c37949019c40d4a5b6309c6905
Cr-Commit-Position: refs/heads/master@{#374678}

[oystein (OOO til 10th of July), 2016-02-05 22:49:11]

Description was changed from

==========
Tracing: Removed monitoring mode

BUG=
==========

to

==========
Tracing: Removed monitoring mode

This is not used by anyone it seems, and prevents ConvertableToTraceFormat from
being used in a thread-safe manner.

BUG=559117
==========

[oystein (OOO til 10th of July), 2016-02-05 22:49:12]

oysteine@chromium.org changed reviewers:
+ primiano@chromium.org, simonhatch@chromium.org

[oystein (OOO til 10th of July), 2016-02-05 22:49:27]

ptal

[oystein (OOO til 10th of July), 2016-02-05 22:58:24]

Description was changed from

==========
Tracing: Removed monitoring mode

This is not used by anyone it seems, and prevents ConvertableToTraceFormat from
being used in a thread-safe manner.

BUG=559117
==========

to

==========
Tracing: Removed monitoring mode

This is not used by anyone it seems, and prevents ConvertableToTraceFormat from
being used in a thread-safe manner.

NOTE: Dependent on https://codereview.chromium.org/1673893002 landing in
Catapult first.

BUG=559117
==========

[Primiano Tucci (use gerrit), 2016-02-08 10:45:22]

OMG yess! Reviewing this CL was SO PLEASURABLE!
LGTM with only one comment, plz look at that.
I think that the forked tracing code in Skia might rely on the enum values.
In doubt, I'd leave them as they are.

Super thanks! Really!

https://codereview.chromium.org/1678503002/diff/1/base/trace_event/trace_log.h
File base/trace_event/trace_log.h (left):

https://codereview.chromium.org/1678503002/diff/1/base/trace_event/trace_log....
base/trace_event/trace_log.h:62: ENABLED_FOR_MONITORING = 1 << 1,
Isn't this going to break skia?
IIRC they have a forked copy of this in
third_party/skia/include/utils/SkEventTracer.h, I wonder if their enum at some
point flows into base/ and we need to keep them in sync.

[nduca, 2016-02-08 17:21:40]

nduca@chromium.org changed reviewers:
+ nduca@chromium.org

[nduca, 2016-02-08 17:21:40]

lgtm also

[oystein (OOO til 10th of July), 2016-02-08 21:49:23]

Thanks!

On 2016/02/08 10:45:22, Primiano Tucci wrote:
> OMG yess! Reviewing this CL was SO PLEASURABLE!
> LGTM with only one comment, plz look at that.
> I think that the forked tracing code in Skia might rely on the enum values.
> In doubt, I'd leave them as they are.
> 
> Super thanks! Really!
> 
> https://codereview.chromium.org/1678503002/diff/1/base/trace_event/trace_log.h
> File base/trace_event/trace_log.h (left):
> 
>
https://codereview.chromium.org/1678503002/diff/1/base/trace_event/trace_log....
> base/trace_event/trace_log.h:62: ENABLED_FOR_MONITORING = 1 << 1,
> Isn't this going to break skia?
> IIRC they have a forked copy of this in
> third_party/skia/include/utils/SkEventTracer.h, I wonder if their enum at some
> point flows into base/ and we need to keep them in sync.

I couldn't find any usage outside of base/, but yeah you're right, might as well
leave them unchanged.

[oystein (OOO til 10th of July), 2016-02-09 00:10:12]

oysteine@chromium.org changed reviewers:
+ sievers@chromium.org

[oystein (OOO til 10th of July), 2016-02-09 00:10:25]

+sievers for content/public/browser/

[fmeawad, 2016-02-09 00:11:38]

fmeawad@chromium.org changed reviewers:
+ fmeawad@chromium.org

[fmeawad, 2016-02-09 00:11:39]

https://codereview.chromium.org/1678503002/diff/1/base/trace_event/trace_log.h
File base/trace_event/trace_log.h (left):

https://codereview.chromium.org/1678503002/diff/1/base/trace_event/trace_log....
base/trace_event/trace_log.h:62: ENABLED_FOR_MONITORING = 1 << 1,
On 2016/02/08 10:45:21, Primiano Tucci wrote:
> Isn't this going to break skia?
> IIRC they have a forked copy of this in
> third_party/skia/include/utils/SkEventTracer.h, I wonder if their enum at some
> point flows into base/ and we need to keep them in sync.

There is also a copy in V8 that I plan to update.

[no sievers, 2016-02-09 21:58:39]

On 2016/02/09 00:10:25, Oystein wrote:
> +sievers for content/public/browser/

lgtm

[oystein (OOO til 10th of July), 2016-02-09 22:52:32]

The CQ bit was checked by oysteine@chromium.org

[oystein (OOO til 10th of July), 2016-02-09 22:52:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org, nduca@chromium.org
Link to the patchset: https://codereview.chromium.org/1678503002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-02-09 22:55:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678503002/20001

[commit-bot: I haz the power, 2016-02-09 23:15:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 23:15:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oystein (OOO til 10th of July), 2016-02-10 16:54:09]

oysteine@chromium.org changed reviewers:
+ dcheng@chromium.org

[oystein (OOO til 10th of July), 2016-02-10 16:54:34]

+dcheng for components/tracing/tracing_messages.h

[dcheng, 2016-02-10 16:59:55]

RS LGTM for IPC changes

[dcheng, 2016-02-10 16:59:58]

RS LGTM for IPC changes

[oystein (OOO til 10th of July), 2016-02-10 17:24:15]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2016-02-10 17:24:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678503002/20001

[commit-bot: I haz the power, 2016-02-10 17:41:59]

Description was changed from

==========
Tracing: Removed monitoring mode

This is not used by anyone it seems, and prevents ConvertableToTraceFormat from
being used in a thread-safe manner.

NOTE: Dependent on https://codereview.chromium.org/1673893002 landing in
Catapult first.

BUG=559117
==========

to

==========
Tracing: Removed monitoring mode

This is not used by anyone it seems, and prevents ConvertableToTraceFormat from
being used in a thread-safe manner.

NOTE: Dependent on https://codereview.chromium.org/1673893002 landing in
Catapult first.

BUG=559117
==========

[commit-bot: I haz the power, 2016-02-10 17:42:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-10 17:43:49]

Description was changed from

==========
Tracing: Removed monitoring mode

This is not used by anyone it seems, and prevents ConvertableToTraceFormat from
being used in a thread-safe manner.

NOTE: Dependent on https://codereview.chromium.org/1673893002 landing in
Catapult first.

BUG=559117
==========

to

==========
Tracing: Removed monitoring mode

This is not used by anyone it seems, and prevents ConvertableToTraceFormat from
being used in a thread-safe manner.

NOTE: Dependent on https://codereview.chromium.org/1673893002 landing in
Catapult first.

BUG=559117

Committed: https://crrev.com/166c6e0b0157f7c37949019c40d4a5b6309c6905
Cr-Commit-Position: refs/heads/master@{#374678}
==========

[commit-bot: I haz the power, 2016-02-10 17:43:50]

Patchset 2 (id:??) landed as
https://crrev.com/166c6e0b0157f7c37949019c40d4a5b6309c6905
Cr-Commit-Position: refs/heads/master@{#374678}