Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2933313002: CWVWebView integration test for state restoration. (Closed)

Created:
3 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CWVWebView integration test for state restoration. This test verifies saving and restoring of the following properties: - lastCommittedURL - visibleURL - canGoBack - canGoForward BUG=None Review-Url: https://codereview.chromium.org/2933313002 Cr-Commit-Position: refs/heads/master@{#479274} Committed: https://chromium.googlesource.com/chromium/src/+/ab568870f4593fd1fe311ede82ca421125426bb3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use CreateWebView inside CreateWebViewWithState #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M ios/web_view/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ios/web_view/test/chrome_web_view_restorable_state_inttest.mm View 1 1 chunk +73 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
Eugene But (OOO till 7-30)
PTAL
3 years, 6 months ago (2017-06-13 07:50:48 UTC) #2
Hiroshi Ichikawa
lgtm
3 years, 6 months ago (2017-06-13 09:11:52 UTC) #3
michaeldo
lgtm. Thank you for adding this test! https://codereview.chromium.org/2933313002/diff/1/ios/web_view/test/chrome_web_view_restorable_state_inttest.mm File ios/web_view/test/chrome_web_view_restorable_state_inttest.mm (right): https://codereview.chromium.org/2933313002/diff/1/ios/web_view/test/chrome_web_view_restorable_state_inttest.mm#newcode45 ios/web_view/test/chrome_web_view_restorable_state_inttest.mm:45: typedef ios_web_view::ChromeWebViewTest ...
3 years, 6 months ago (2017-06-13 14:51:35 UTC) #4
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/2933313002/diff/1/ios/web_view/test/chrome_web_view_restorable_state_inttest.mm File ios/web_view/test/chrome_web_view_restorable_state_inttest.mm (right): https://codereview.chromium.org/2933313002/diff/1/ios/web_view/test/chrome_web_view_restorable_state_inttest.mm#newcode45 ios/web_view/test/chrome_web_view_restorable_state_inttest.mm:45: typedef ios_web_view::ChromeWebViewTest ChromeWebViewRestorableStateTest; On 2017/06/13 14:51:35, michaeldo wrote: ...
3 years, 6 months ago (2017-06-14 00:54:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933313002/20001
3 years, 6 months ago (2017-06-14 01:39:46 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 03:41:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ab568870f4593fd1fe311ede82ca...

Powered by Google App Engine
This is Rietveld 408576698