Correctly update CWVWebView properties on state restoration.

Correctly update CWVWebView properties on state restoration.

This has regressed when properties were made KVO compiant.

BUG=704038
Review-Url: https://codereview.chromium.org/2935923002
Cr-Commit-Position: refs/heads/master@{#479235}
Committed: https://chromium.googlesource.com/chromium/src/+/bff5dcfbfafd7a80aedbfebb97161d9bbeedcf2f

[Eugene But (OOO till 7-30), 2017-06-13 07:33:38]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 07:33:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-06-13 07:34:18]

eugenebut@chromium.org changed reviewers:
+ ichikawa@chromium.org, michaeldo@chromium.org

[Eugene But (OOO till 7-30), 2017-06-13 07:34:19]

PTAL

[Hiroshi Ichikawa, 2017-06-13 07:40:11]

lgtm

Thanks for the fix!

https://codereview.chromium.org/2935923002/diff/1/ios/web_view/internal/cwv_w...
File ios/web_view/internal/cwv_web_view.mm (right):

https://codereview.chromium.org/2935923002/diff/1/ios/web_view/internal/cwv_w...
ios/web_view/internal/cwv_web_view.mm:381: self.title =
base::SysUTF16ToNSString(_webState->GetTitle());
Optional: Maybe factor this out to -updateTitle method in analogous to
-updateCurrentUrls?

[commit-bot: I haz the power, 2017-06-13 07:46:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 07:46:26]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-06-13 07:56:41]

Thanks for a quick review!

https://codereview.chromium.org/2935923002/diff/1/ios/web_view/internal/cwv_w...
File ios/web_view/internal/cwv_web_view.mm (right):

https://codereview.chromium.org/2935923002/diff/1/ios/web_view/internal/cwv_w...
ios/web_view/internal/cwv_web_view.mm:381: self.title =
base::SysUTF16ToNSString(_webState->GetTitle());
On 2017/06/13 07:40:11, Hiroshi Ichikawa wrote:
> Optional: Maybe factor this out to -updateTitle method in analogous to
> -updateCurrentUrls?

Done.

[michaeldo, 2017-06-13 14:40:26]

LGTM!

[Eugene But (OOO till 7-30), 2017-06-14 00:46:11]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-06-14 00:46:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
ichikawa@chromium.org
Link to the patchset: https://codereview.chromium.org/2935923002/#ps20001
(title: "Factored code to updateTitle")

[commit-bot: I haz the power, 2017-06-14 00:46:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 01:01:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497401171061010,
"parent_rev": "eed319f1ecb65dd20c8dfc8eed0ea26e29d65922", "commit_rev":
"bff5dcfbfafd7a80aedbfebb97161d9bbeedcf2f"}

[commit-bot: I haz the power, 2017-06-14 01:01:20]

Description was changed from

==========
Correctly update CWVWebView properties on state restoration.

This has regressed when properties were made KVO compiant.

BUG=704038
==========

to

==========
Correctly update CWVWebView properties on state restoration.

This has regressed when properties were made KVO compiant.

BUG=704038

Review-Url: https://codereview.chromium.org/2935923002
Cr-Commit-Position: refs/heads/master@{#479235}
Committed:
https://chromium.googlesource.com/chromium/src/+/bff5dcfbfafd7a80aedbfebb9716...
==========

[commit-bot: I haz the power, 2017-06-14 01:01:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bff5dcfbfafd7a80aedbfebb9716...