[DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor

[DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor

Session now handles the state cookie and messages waiting for response.
This will also help with multiple sessions.

BUG=590878
Review-Url: https://codereview.chromium.org/2933243002
Cr-Commit-Position: refs/heads/master@{#480170}
Committed: https://chromium.googlesource.com/chromium/src/+/c97486f93ac2360cb9d7b8a29aa5a624da3fb2df

[dgozman, 2017-06-13 01:11:47]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 01:12:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-06-13 01:16:19]

Description was changed from

==========
[DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor

Session now handles the state cookie and messages waiting for response.

BUG=none
==========

to

==========
[DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor

Session now handles the state cookie and messages waiting for response.

BUG=590878
==========

[commit-bot: I haz the power, 2017-06-13 03:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 03:10:36]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-06-13 17:21:50]

Description was changed from

==========
[DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor

Session now handles the state cookie and messages waiting for response.

BUG=590878
==========

to

==========
[DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor

Session now handles the state cookie and messages waiting for response.
This will also help with multiple sessions.

BUG=590878
==========

[dgozman, 2017-06-13 17:22:17]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2017-06-13 17:22:18]

Could you please take a look?

[caseq, 2017-06-13 19:52:26]

lgtm

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
File content/browser/devtools/devtools_session.cc (right):

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_session.cc:53: if (session_id != session_id_)
nit: I wonder if this check would make more sense in chunk processor now.

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
File content/browser/devtools/devtools_session.h (right):

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_session.h:8: #include <unordered_map>
consider using regular maps? see
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/rdxOHKzQmRY/fgMJC...
for reasons why.

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_session.h:88: MessageByCallId
waiting_for_response_messages_;
nit: messages_waiting_for_response_?

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
File content/browser/devtools/render_frame_devtools_agent_host.h (right):

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
content/browser/devtools/render_frame_devtools_agent_host.h:174:
std::unordered_set<NavigationHandleImpl*> navigation_handles_;
flat_set? ;)

[dgozman, 2017-06-16 17:58:46]

Thank you for review!

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
File content/browser/devtools/devtools_session.cc (right):

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_session.cc:53: if (session_id != session_id_)
On 2017/06/13 19:52:25, caseq wrote:
> nit: I wonder if this check would make more sense in chunk processor now.

Right. I will probably follow up by inlining chunk processor into session
directly, so that we don't have extra indirection.

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
File content/browser/devtools/devtools_session.h (right):

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_session.h:8: #include <unordered_map>
On 2017/06/13 19:52:26, caseq wrote:
> consider using regular maps? see
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/rdxOHKzQmRY/fgMJC...
> for reasons why.

Done.

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_session.h:88: MessageByCallId
waiting_for_response_messages_;
On 2017/06/13 19:52:26, caseq wrote:
> nit: messages_waiting_for_response_?

Acknowledged.

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
File content/browser/devtools/render_frame_devtools_agent_host.h (right):

https://codereview.chromium.org/2933243002/diff/20001/content/browser/devtool...
content/browser/devtools/render_frame_devtools_agent_host.h:174:
std::unordered_set<NavigationHandleImpl*> navigation_handles_;
On 2017/06/13 19:52:26, caseq wrote:
> flat_set? ;)

Done.

[dgozman, 2017-06-16 17:58:53]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 17:59:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 19:08:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 19:08:53]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-06-16 21:07:51]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-06-16 21:07:52]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2933243002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-06-16 21:08:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 21:12:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497647271857990,
"parent_rev": "da58dc6dc45f1be6496a1819bad563de20fead00", "commit_rev":
"c97486f93ac2360cb9d7b8a29aa5a624da3fb2df"}

[commit-bot: I haz the power, 2017-06-16 21:12:55]

Description was changed from

==========
[DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor

Session now handles the state cookie and messages waiting for response.
This will also help with multiple sessions.

BUG=590878
==========

to

==========
[DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor

Session now handles the state cookie and messages waiting for response.
This will also help with multiple sessions.

BUG=590878

Review-Url: https://codereview.chromium.org/2933243002
Cr-Commit-Position: refs/heads/master@{#480170}
Committed:
https://chromium.googlesource.com/chromium/src/+/c97486f93ac2360cb9d7b8a29aa5...
==========

[commit-bot: I haz the power, 2017-06-16 21:12:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c97486f93ac2360cb9d7b8a29aa5...