Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.h

Issue 2933243002: [DevTools] Make DevToolsSession own it's DevToolsMessageChunkProcessor (Closed)
Patch Set: addressed comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.h
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.h b/content/browser/devtools/render_frame_devtools_agent_host.h
index 675990f59986d0957e2836d8e8b8f33669b3b943..f63a57d1a2566066ba9498b8ee006c1b9e6cbf9a 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.h
+++ b/content/browser/devtools/render_frame_devtools_agent_host.h
@@ -7,9 +7,9 @@
#include <map>
#include <memory>
-#include <unordered_set>
#include "base/compiler_specific.h"
+#include "base/containers/flat_set.h"
#include "base/macros.h"
#include "build/build_config.h"
#include "content/browser/devtools/devtools_agent_host_impl.h"
@@ -171,22 +171,18 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
// The active host we are talking to.
RenderFrameHostImpl* frame_host_ = nullptr;
+ base::flat_set<NavigationHandleImpl*> navigation_handles_;
+ bool render_frame_alive_ = false;
+
+ // These messages were queued after suspending, not sent to the agent,
+ // and will be sent after resuming.
struct Message {
int session_id;
+ int call_id;
std::string method;
std::string message;
};
- // Chunk processor's state cookie always corresponds to a state before
- // any of the suspended or waiting for response messages have been handled.
- DevToolsMessageChunkProcessor chunk_processor_;
- std::unordered_set<NavigationHandleImpl*> navigation_handles_;
- bool render_frame_alive_ = false;
- // These messages were sent before suspending, but their result have not been
- // received yet, and state cookie has not been updated.
- std::map<int, Message> waiting_for_response_messages_;
- // These messages were queued after suspending, not sent to the agent,
- // and will be sent after resuming.
- std::map<int, Message> suspended_messages_;
+ std::vector<Message> suspended_messages_;
// The FrameTreeNode associated with this agent.
FrameTreeNode* frame_tree_node_;
« no previous file with comments | « content/browser/devtools/devtools_session.cc ('k') | content/browser/devtools/render_frame_devtools_agent_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698