Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2933213002: Revert of Move ObjectContentType entirely to HTMLPlugInElement (Closed)

Created:
3 years, 6 months ago by Devlin
Modified:
3 years, 6 months ago
CC:
chromium-reviews, blink-reviews-html_chromium.org, dglazkov+blink, blink-reviews, blink-reviews-frames_chromium.org, kinuko+watch, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ObjectContentType entirely to HTMLPlugInElement (patchset #2 id:20001 of https://codereview.chromium.org/2927703003/ ) Reason for revert: Looks like schenney's unavailable at the moment; speculatively reverting for layout test virtual/new-remote-playback-pipeline/media/controls/controls-cast-overlay-slow-fade.html failures (e.g. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/57955) Original issue's description: > Move ObjectContentType entirely to HTMLPlugInElement > > There's no need to go to LocalFrameClientImpl to determine how to load > a plugin element, that was a purely pre-blink necessity. > > Simplify a bunch of logic around HTMLPlugInElement to assume that url_ > and service_type_ are always set and correct by the time the > ObjectContentType is being determined. > > BUG= > > Review-Url: https://codereview.chromium.org/2927703003 > Cr-Commit-Position: refs/heads/master@{#478683} > Committed: https://chromium.googlesource.com/chromium/src/+/2718186cc8ac74b38b9a7304764642f05c76bb81 TBR=schenney@chromium.org,japhet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2933213002 Cr-Commit-Position: refs/heads/master@{#478781} Committed: https://chromium.googlesource.com/chromium/src/+/0c41b90c5acfe8b728cca4829ee0952015e0beca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -92 lines) Patch
M third_party/WebKit/Source/core/frame/LocalFrameClient.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 5 chunks +50 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.h View 2 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 6 chunks +56 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderTypes.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Devlin
Created Revert of Move ObjectContentType entirely to HTMLPlugInElement
3 years, 6 months ago (2017-06-12 21:53:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933213002/1
3 years, 6 months ago (2017-06-12 21:53:51 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 21:54:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c41b90c5acfe8b728cca4829ee0...

Powered by Google App Engine
This is Rietveld 408576698