 Chromium Code Reviews
 Chromium Code Reviews Issue 
            2933213002:
    Revert of Move ObjectContentType entirely to HTMLPlugInElement  (Closed)
    
  
    Issue 
            2933213002:
    Revert of Move ObjectContentType entirely to HTMLPlugInElement  (Closed) 
  | DescriptionRevert of Move ObjectContentType entirely to HTMLPlugInElement (patchset #2 id:20001 of https://codereview.chromium.org/2927703003/ )
Reason for revert:
Looks like schenney's unavailable at the moment; speculatively reverting for layout test virtual/new-remote-playback-pipeline/media/controls/controls-cast-overlay-slow-fade.html failures (e.g. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/57955)
Original issue's description:
> Move ObjectContentType entirely to HTMLPlugInElement
> 
> There's no need to go to LocalFrameClientImpl to determine how to load
> a plugin element, that was a purely pre-blink necessity.
> 
> Simplify a bunch of logic around HTMLPlugInElement to assume that url_
> and service_type_ are always set and correct by the time the
> ObjectContentType is being determined.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2927703003
> Cr-Commit-Position: refs/heads/master@{#478683}
> Committed: https://chromium.googlesource.com/chromium/src/+/2718186cc8ac74b38b9a7304764642f05c76bb81
TBR=schenney@chromium.org,japhet@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2933213002
Cr-Commit-Position: refs/heads/master@{#478781}
Committed: https://chromium.googlesource.com/chromium/src/+/0c41b90c5acfe8b728cca4829ee0952015e0beca
   Patch Set 1 #Messages
    Total messages: 6 (3 generated)
     |