Move ObjectContentType entirely to HTMLPlugInElement

Move ObjectContentType entirely to HTMLPlugInElement

There's no need to go to LocalFrameClientImpl to determine how to load
a plugin element, that was a purely pre-blink necessity.

Simplify a bunch of logic around HTMLPlugInElement to assume that url_
and service_type_ are always set and correct by the time the
ObjectContentType is being determined.

BUG=

Review-Url: https://codereview.chromium.org/2927703003
Cr-Commit-Position: refs/heads/master@{#478683}
Committed: https://chromium.googlesource.com/chromium/src/+/2718186cc8ac74b38b9a7304764642f05c76bb81

[Nate Chapin, 2017-06-07 18:06:38]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 18:08:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 20:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 20:20:38]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2017-06-07 23:59:39]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 00:00:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 03:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 03:53:30]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2017-06-08 18:00:34]

Description was changed from

==========
Move ObjectContentType entirely to HTMLPlugInElement

BUG=
==========

to

==========
Move ObjectContentType entirely to HTMLPlugInElement

There's no need to go to LocalFrameClientImpl to determine how to load
a plugin element, that was a purely pre-blink necessity.

Simplify a bunch of logic around HTMLPlugInElement to assume that url_
and service_type_ are always set and correct by the time the
ObjectContentType is being determined.

BUG=
==========

[Nate Chapin, 2017-06-08 18:07:01]

japhet@chromium.org changed reviewers:
+ schenney@chromium.org

[Nate Chapin, 2017-06-08 18:07:02]

Hi schenney@, would you mind reviewing this cleanup?

I'm not actually fixing any of your TODOs in HTMLObjectElement, but I'm cleaning
up code in its vicinity, so I'm guessing you're the best reviewer. :)

https://codereview.chromium.org/2927703003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLObjectElement.cpp (left):

https://codereview.chromium.org/2927703003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLObjectElement.cpp:194: if
(MIMETypeRegistry::IsJavaAppletMIMEType(service_type)) {
This should be unnecessary now that we never instantiated java.

https://codereview.chromium.org/2927703003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLObjectElement.cpp:220: if
(ShouldUsePlugin(completed_url, service_type, false, use_fallback))
I can't find any evidence that we need to check ShouldUsePlugin() here. We'll
just fall back to checking it when RequestObject() is called. Dropping this
allows us to just check url_ and service_type_ directly in
GetObjectContentType() and other places in HTMLPlugInElement.

[Stephen Chennney, 2017-06-12 15:31:30]

I'm not a real expert here, but it does look OK to me.

Browser tests cover some of this code more thoroughly, so look out for failures
once you commit.

LGTM.

[Nate Chapin, 2017-06-12 16:22:34]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2017-06-12 16:23:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 18:14:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497284554382340,
"parent_rev": "6f3959909052a12a0355a1114d4e802980cb27e8", "commit_rev":
"2718186cc8ac74b38b9a7304764642f05c76bb81"}

[commit-bot: I haz the power, 2017-06-12 18:14:28]

Description was changed from

==========
Move ObjectContentType entirely to HTMLPlugInElement

There's no need to go to LocalFrameClientImpl to determine how to load
a plugin element, that was a purely pre-blink necessity.

Simplify a bunch of logic around HTMLPlugInElement to assume that url_
and service_type_ are always set and correct by the time the
ObjectContentType is being determined.

BUG=
==========

to

==========
Move ObjectContentType entirely to HTMLPlugInElement

There's no need to go to LocalFrameClientImpl to determine how to load
a plugin element, that was a purely pre-blink necessity.

Simplify a bunch of logic around HTMLPlugInElement to assume that url_
and service_type_ are always set and correct by the time the
ObjectContentType is being determined.

BUG=

Review-Url: https://codereview.chromium.org/2927703003
Cr-Commit-Position: refs/heads/master@{#478683}
Committed:
https://chromium.googlesource.com/chromium/src/+/2718186cc8ac74b38b9a73047646...
==========

[commit-bot: I haz the power, 2017-06-12 18:14:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2718186cc8ac74b38b9a73047646...

[huangs, 2017-06-12 21:45:23]

Look's like controls-cast-overlay-slow-fade.html is consistently failing after
this patch; PTAL?

[Nate Chapin, 2017-06-12 21:51:29]

On 2017/06/12 21:45:23, huangs wrote:
> Look's like controls-cast-overlay-slow-fade.html is consistently failing after
> this patch; PTAL?

I don't immediately see how a plugin-related change would break that test, but
I'm looking.

[Devlin, 2017-06-12 21:53:25]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2933213002/ by rdevlin.cronin@chromium.org.

The reason for reverting is: Looks like schenney's unavailable at the moment;
speculatively reverting for layout test
virtual/new-remote-playback-pipeline/media/controls/controls-cast-overlay-slow-fade.html
failures (e.g.
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/57955).