Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2933163002: Revert of Remove find_dependencies script (Closed)

Created:
3 years, 6 months ago by nednguyen
Modified:
3 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove find_dependencies script (patchset #1 id:1 of https://codereview.chromium.org/2932213002/ ) Reason for revert: find_dependencies is still used. Original issue's description: > Remove find_dependencies script > > BUG=chromium:728177 > > Review-Url: https://codereview.chromium.org/2932213002 > Cr-Commit-Position: refs/heads/master@{#478658} > Committed: https://chromium.googlesource.com/chromium/src/+/e5ee4f9d1a7815c320dadb315675449a710c19aa TBR=charliea@chromium.org,stevenjb@chromium.org,achuith@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:728177 Review-Url: https://codereview.chromium.org/2933163002 Cr-Commit-Position: refs/heads/master@{#478675} Committed: https://chromium.googlesource.com/chromium/src/+/683a4557dae870a6a387bc739b6cdc89280e99d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+808 lines, -0 lines) Patch
A tools/perf/core/bootstrap.py View 1 chunk +161 lines, -0 lines 0 comments Download
A tools/perf/core/find_dependencies.py View 1 chunk +252 lines, -0 lines 0 comments Download
A tools/perf/core/find_dependencies_unittest.py View 1 chunk +48 lines, -0 lines 0 comments Download
A tools/perf/find_dependencies View 1 chunk +12 lines, -0 lines 0 comments Download
A tools/perf/third_party/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/perf/third_party/davclient/README.chromium View 1 chunk +17 lines, -0 lines 0 comments Download
A tools/perf/third_party/davclient/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/perf/third_party/davclient/davclient.py View 1 chunk +312 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nednguyen
Created Revert of Remove find_dependencies script
3 years, 6 months ago (2017-06-12 17:58:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933163002/1
3 years, 6 months ago (2017-06-12 17:58:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/683a4557dae870a6a387bc739b6cdc89280e99d6
3 years, 6 months ago (2017-06-12 17:59:42 UTC) #7
achuithb
3 years, 6 months ago (2017-06-12 19:29:53 UTC) #8
Message was sent while issue was closed.
Thank you!

Powered by Google App Engine
This is Rietveld 408576698