Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2932213002: Remove find_dependencies script (Closed)

Created:
3 years, 6 months ago by nednguyen
Modified:
3 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove find_dependencies script BUG=chromium:728177 Review-Url: https://codereview.chromium.org/2932213002 Cr-Commit-Position: refs/heads/master@{#478658} Committed: https://chromium.googlesource.com/chromium/src/+/e5ee4f9d1a7815c320dadb315675449a710c19aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -808 lines) Patch
D tools/perf/core/bootstrap.py View 1 chunk +0 lines, -161 lines 0 comments Download
D tools/perf/core/find_dependencies.py View 1 chunk +0 lines, -252 lines 0 comments Download
D tools/perf/core/find_dependencies_unittest.py View 1 chunk +0 lines, -48 lines 0 comments Download
D tools/perf/find_dependencies View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/perf/third_party/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/perf/third_party/davclient/README.chromium View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/perf/third_party/davclient/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/perf/third_party/davclient/davclient.py View 1 chunk +0 lines, -312 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
nednguyen
3 years, 6 months ago (2017-06-12 14:06:02 UTC) #6
charliea (OOO until 10-5)
lgtm
3 years, 6 months ago (2017-06-12 14:51:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932213002/1
3 years, 6 months ago (2017-06-12 15:04:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e5ee4f9d1a7815c320dadb315675449a710c19aa
3 years, 6 months ago (2017-06-12 16:34:35 UTC) #12
achuithb
On 2017/06/12 16:34:35, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 6 months ago (2017-06-12 17:57:20 UTC) #13
achuithb
3 years, 6 months ago (2017-06-12 17:57:39 UTC) #15
nednguyen
3 years, 6 months ago (2017-06-12 17:58:21 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2933163002/ by nednguyen@google.com.

The reason for reverting is: find_dependencies is still used..

Powered by Google App Engine
This is Rietveld 408576698