Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 2933083002: Revert of Align `clear-site-data` syntax with the spec. (Closed)

Created:
3 years, 6 months ago by Mike West
Modified:
3 years, 6 months ago
Reviewers:
msramek
CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, fuzzing_chromium.org, jam, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Align `clear-site-data` syntax with the spec. (patchset #2 id:20001 of https://codereview.chromium.org/2929593002/ ) Reason for revert: Despite passing all the bots, this apparently breaks `content_browsertests`: https://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=57936. So, let's go fix that. Original issue's description: > Align `clear-site-data` syntax with the spec. > > We've shifted from an explicit JSON dictionary to a list of quoted > strings (that can be parsed as JSON for forward-compatibility). That is, > rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`, > we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing. > > Spec change in https://github.com/w3c/webappsec-clear-site-data/issues/27. > > BUG=607897 > > Review-Url: https://codereview.chromium.org/2929593002 > Cr-Commit-Position: refs/heads/master@{#478585} > Committed: https://chromium.googlesource.com/chromium/src/+/085b57ffe70b6cb90cd77b61585babcf59df3a95 TBR=msramek@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607897 Review-Url: https://codereview.chromium.org/2933083002 Cr-Commit-Position: refs/heads/master@{#478594} Committed: https://chromium.googlesource.com/chromium/src/+/b6ad2b157c987fe2d64e07990b83654ac9830a85

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
Mike West
Created Revert of Align `clear-site-data` syntax with the spec.
3 years, 6 months ago (2017-06-12 12:01:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933083002/1
3 years, 6 months ago (2017-06-12 12:01:32 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 12:02:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6ad2b157c987fe2d64e07990b83...

Powered by Google App Engine
This is Rietveld 408576698