Align `clear-site-data` syntax with the spec.

Align `clear-site-data` syntax with the spec.

We've shifted from an explicit JSON dictionary to a list of quoted
strings (that can be parsed as JSON for forward-compatibility). That is,
rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`,
we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing.

Spec change in https://github.com/w3c/webappsec-clear-site-data/issues/27.

BUG=607897
Review-Url: https://codereview.chromium.org/2929593002
Cr-Commit-Position: refs/heads/master@{#478585}
Committed: https://chromium.googlesource.com/chromium/src/+/085b57ffe70b6cb90cd77b61585babcf59df3a95

[Mike West, 2017-06-07 10:29:07]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 10:29:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike West, 2017-06-07 10:29:56]

Description was changed from

==========
Align `clear-site-data` syntax with the spec.

We've shifted from an explicit JSON dictionary to a list of quoted
strings (that can be parsed as JSON for forward-compatibility). That is,
rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`,
we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing.

BUG=607897
==========

to

==========
Align `clear-site-data` syntax with the spec.

We've shifted from an explicit JSON dictionary to a list of quoted
strings (that can be parsed as JSON for forward-compatibility). That is,
rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`,
we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing.

Spec change in https://github.com/w3c/webappsec-clear-site-data/issues/27.

BUG=607897
==========

[Mike West, 2017-06-07 10:30:09]

mkwst@chromium.org changed reviewers:
+ msramek@chromium.org

[Mike West, 2017-06-07 10:30:09]

WDYT, Martin?

[commit-bot: I haz the power, 2017-06-07 12:13:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 12:13:08]

Dry run: This issue passed the CQ dry run.

[msramek, 2017-06-08 09:42:51]

LGTM

https://codereview.chromium.org/2929593002/diff/1/content/browser/browsing_da...
File content/browser/browsing_data/clear_site_data_throttle.cc (right):

https://codereview.chromium.org/2929593002/diff/1/content/browser/browsing_da...
content/browser/browsing_data/clear_site_data_throttle.cc:447: // Wrap |header|
in `[` and `]`, then process it as a JSON array:
JSONReader is discouraged in browser/, and since the new syntax is regular, it
would be ideal to use a custom parser here.

Using a JSONReader here is not a regression, so not necessarily in this CL, but
can you please at least add a TODO?

https://codereview.chromium.org/2929593002/diff/1/content/browser/browsing_da...
File content/browser/browsing_data/clear_site_data_throttle_unittest.cc (right):

https://codereview.chromium.org/2929593002/diff/1/content/browser/browsing_da...
content/browser/browsing_data/clear_site_data_throttle_unittest.cc:418: //
Multiple instances of the header will be parsed correctly.
Should the spec mention coalescing headers, or is that just the default
behavior?

[Mike West, 2017-06-12 09:14:28]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2017-06-12 09:14:29]

The patchset sent to the CQ was uploaded after l-g-t-m from msramek@chromium.org
Link to the patchset: https://codereview.chromium.org/2929593002/#ps20001
(title: "Feedback.")

[commit-bot: I haz the power, 2017-06-12 09:14:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike West, 2017-06-12 09:21:50]

Thanks!

https://codereview.chromium.org/2929593002/diff/1/content/browser/browsing_da...
File content/browser/browsing_data/clear_site_data_throttle.cc (right):

https://codereview.chromium.org/2929593002/diff/1/content/browser/browsing_da...
content/browser/browsing_data/clear_site_data_throttle.cc:447: // Wrap |header|
in `[` and `]`, then process it as a JSON array:
On 2017/06/08 at 09:42:50, msramek (slow) wrote:
> JSONReader is discouraged in browser/, and since the new syntax is regular, it
would be ideal to use a custom parser here.
> 
> Using a JSONReader here is not a regression, so not necessarily in this CL,
but can you please at least add a TODO?

Done.

https://codereview.chromium.org/2929593002/diff/1/content/browser/browsing_da...
File content/browser/browsing_data/clear_site_data_throttle_unittest.cc (right):

https://codereview.chromium.org/2929593002/diff/1/content/browser/browsing_da...
content/browser/browsing_data/clear_site_data_throttle_unittest.cc:418: //
Multiple instances of the header will be parsed correctly.
On 2017/06/08 at 09:42:50, msramek (slow) wrote:
> Should the spec mention coalescing headers, or is that just the default
behavior?

That's the default behavior (see
https://tools.ietf.org/html/rfc7230#section-3.2.2).

[commit-bot: I haz the power, 2017-06-12 10:34:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497258868757640,
"parent_rev": "4fa459890bf3fa250d5a57a5670fe677ed3a075d", "commit_rev":
"085b57ffe70b6cb90cd77b61585babcf59df3a95"}

[commit-bot: I haz the power, 2017-06-12 10:34:55]

Description was changed from

==========
Align `clear-site-data` syntax with the spec.

We've shifted from an explicit JSON dictionary to a list of quoted
strings (that can be parsed as JSON for forward-compatibility). That is,
rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`,
we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing.

Spec change in https://github.com/w3c/webappsec-clear-site-data/issues/27.

BUG=607897
==========

to

==========
Align `clear-site-data` syntax with the spec.

We've shifted from an explicit JSON dictionary to a list of quoted
strings (that can be parsed as JSON for forward-compatibility). That is,
rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`,
we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing.

Spec change in https://github.com/w3c/webappsec-clear-site-data/issues/27.

BUG=607897

Review-Url: https://codereview.chromium.org/2929593002
Cr-Commit-Position: refs/heads/master@{#478585}
Committed:
https://chromium.googlesource.com/chromium/src/+/085b57ffe70b6cb90cd77b61585b...
==========

[commit-bot: I haz the power, 2017-06-12 10:34:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/085b57ffe70b6cb90cd77b61585b...

[findit-for-me, 2017-06-12 11:44:37]

Findit (https://goo.gl/kROfz5) identified this CL at revision 478585 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[Mike West, 2017-06-12 12:01:25]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2933083002/ by mkwst@chromium.org.

The reason for reverting is: Despite passing all the bots, this apparently
breaks `content_browsertests`:
https://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests....
So, let's go fix that..